Skip to content

Commit 351a463

Browse files
authored
Merge pull request #9814 from g-gaston/fix-kubeadm-provider-provider-name-notes
🐛 Fix kubeadm bootstrap prefix in release notes
2 parents 528ac60 + 00fdec0 commit 351a463

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

hack/tools/release/notes/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ var (
8888
"clusterresourceset": "ClusterResourceSet",
8989
"machinedeployment": "MachineDeployment",
9090
"ipam": "IPAM",
91-
"provider/bootstrap-kubeadm": "CAPBK",
91+
"provider/bootstrap-kubeadm": "CABPK",
9292
"provider/infrastructure-in-memory": "CAPIM",
9393
"provider/core": "Core",
9494
"runtime-sdk": "Runtime SDK",

hack/tools/release/notes/release_notes_integration_test.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ func TestReleaseNotesIntegration(t *testing.T) {
3535
name string
3636
previousRelease string
3737
releaseBranchForTest string
38+
head string
3839
expected string
3940
}{
4041
{
@@ -44,6 +45,7 @@ func TestReleaseNotesIntegration(t *testing.T) {
4445
name: "new patch",
4546
previousRelease: "v1.3.9",
4647
releaseBranchForTest: "release-1.3",
48+
head: "release-1.3",
4749
expected: "test/golden/v1.3.10.md",
4850
},
4951
{
@@ -55,13 +57,14 @@ func TestReleaseNotesIntegration(t *testing.T) {
5557
// it represents accurately the HEAD of release-1.5 when we released v1.5.0.
5658
name: "new minor",
5759
previousRelease: "v1.4.0",
58-
releaseBranchForTest: "v1.5.0",
60+
releaseBranchForTest: "v1.5.0-integration-test",
61+
head: "v1.5.0",
5962
expected: "test/golden/v1.5.0.md",
6063
},
6164
}
6265
for _, tc := range testCases {
6366
t.Run(tc.name, func(t *testing.T) {
64-
setupNotesTest(t, tc.previousRelease, tc.releaseBranchForTest)
67+
setupNotesTest(t, tc.previousRelease, tc.releaseBranchForTest, tc.head)
6568
g := NewWithT(t)
6669

6770
expectedOutput, err := os.ReadFile(tc.expected)
@@ -104,7 +107,7 @@ func runReleaseNotesCmd() error {
104107
return nil
105108
}
106109

107-
func setupNotesTest(tb testing.TB, previousRelease, releaseBranchForTest string) {
110+
func setupNotesTest(tb testing.TB, previousRelease, releaseBranchForTest, head string) {
108111
g := NewWithT(tb)
109112

110113
_, err := os.Stat(releaseBranchForTest)
@@ -114,7 +117,7 @@ func setupNotesTest(tb testing.TB, previousRelease, releaseBranchForTest string)
114117
g.Expect(err).To(Succeed())
115118
}
116119

117-
pull := exec.Command("git", "pull", "upstream", releaseBranchForTest)
120+
pull := exec.Command("git", "checkout", head)
118121
pull.Dir = releaseBranchForTest
119122
runCommand(tb, pull)
120123

hack/tools/release/notes/test/golden/v1.5.0.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ REPLACE ME: A couple sentences describing the deprecation, including links to do
2929
- Dependency: Bump to CR v0.15.0 (#8007)
3030

3131
## :sparkles: New Features
32-
- CAPBK: Use caching read for bootstrap config owner (#8867)
32+
- CABPK: Use caching read for bootstrap config owner (#8867)
3333
- CAPIM: Enable Kubernetes upgrades in CAPIM (#8938)
3434
- ClusterClass: Add support or concurrent MD upgrades in classy clusters (#8432)
3535
- ClusterClass: Add webhook warning for missing ClusterClass (#8746)
@@ -52,8 +52,8 @@ REPLACE ME: A couple sentences describing the deprecation, including links to do
5252
## :bug: Bug Fixes
5353
- API: All: only set finalizers if deletionTimestamp is not set (#8949)
5454
- API: Ensure ownerReference apiVersions are always up to date (#8256)
55-
- CAPBK: Ignition: start kubeadm after network.target (#8772)
56-
- CAPBK: Set uninitialized taint only on worker nodes (#8358)
55+
- CABPK: Ignition: start kubeadm after network.target (#8772)
56+
- CABPK: Set uninitialized taint only on worker nodes (#8358)
5757
- CAPD: Add kind mapper (#8880)
5858
- CAPD: Change the haproxy entrypoint to prevent getting stopped immediately after start (#8685)
5959
- CAPD: Delegate CAPD port selection to the container runtime (#8642)
@@ -120,7 +120,7 @@ REPLACE ME: A couple sentences describing the deprecation, including links to do
120120

121121
## :seedling: Others
122122
- API: Deprecate v1alpha3 and v1alpha4 in CRDs (#8687)
123-
- CAPBK: Replace reflect deepequal in bootstrap kubeadm (#8266)
123+
- CABPK: Replace reflect deepequal in bootstrap kubeadm (#8266)
124124
- CAPD: Automatically set kubelet args for capd (#8881)
125125
- CAPD: Only ignore necessary kubeadm preflight errors (#7911)
126126
- CAPIM: Add ClusterClass support for in-memory provider (#8807)
@@ -271,7 +271,7 @@ REPLACE ME: A couple sentences describing the deprecation, including links to do
271271
- MachineDeployment: Drop the first return value from FindOldMachineSets (#8415)
272272
- MachineSet: Add MachineFinalizer during machine computation (#8463)
273273
- MachineSet: Surface failed preflight checks on MachineSet in `MachinesCreated` condition (#8669)
274-
- MULTIPLE_AREAS[ClusterCacheTracker/KCP/CAPBK]: Cache secrets in KCP, CABPK and ClusterCacheTracker (#8940)
274+
- MULTIPLE_AREAS[ClusterCacheTracker/KCP/CABPK]: Cache secrets in KCP, CABPK and ClusterCacheTracker (#8940)
275275
- Release: Add area label lookup for prefixes to release notes tool (#8780)
276276
- Release: Add runtime extension components to release (#8438)
277277
- Release: Bump kpromo to v3.5.1 (#8301)

0 commit comments

Comments
 (0)