Address comments

Author: fabriziopandini

api/v1alpha3/condition_consts.go

@@ -28,8 +28,8 @@ const (
 
 // Conditions and condition Reasons for the Machine object
 
-// MachineConditionsCount defines the total number of conditions on the Machine object.
-const MachineConditionsCount = 2
+// MachineSummaryConditionsCount defines the total number of conditions on the Machine object.
+const MachineSummaryConditionsCount = 2
 
 const (
 	// BootstrapReadyCondition reports a summary of current status of the bootstrap object defined for this machine.

controllers/machine_controller.go

@@ -169,9 +169,9 @@ func (r *MachineReconciler) Reconcile(req ctrl.Request) (_ ctrl.Result, reterr e
 	defer func() {
 		// always update the readyCondition with the summary of the machine conditions.
 		conditions.SetSummary(m,
-			// we want to surface infrastructure problems as firsts, then the others.
+			// we want to surface infrastructure problems first, then the others.
 			conditions.WithConditionOrder(clusterv1.InfrastructureReadyCondition),
-			conditions.WithStepCounter(clusterv1.MachineConditionsCount),
+			conditions.WithStepCounter(clusterv1.MachineSummaryConditionsCount),
 		)
 
 		r.reconcilePhase(ctx, m)

controllers/machine_controller_phases.go

@@ -193,6 +193,7 @@ func (r *MachineReconciler) reconcileBootstrap(ctx context.Context, cluster *clu
 	// If the bootstrap data is populated, set ready and return.
 	if m.Spec.Bootstrap.DataSecretName != nil {
 		m.Status.BootstrapReady = true
+		conditions.MarkTrue(m, clusterv1.BootstrapReadyCondition)
 		return nil
 	}