address comments

Author: fabriziopandini

cmd/clusterctl/pkg/client/cluster/objectgraph_test.go

@@ -1092,7 +1092,7 @@ func Test_objectGraph_setSoftOwnership(t *testing.T) {
 			fields: fields{
 				objs: test.NewFakeCluster("ns1", "foo").Objs(),
 			},
-			wantSecrets: map[string][]string{ // wantSecrets is a map[Cluster.UID] --> list of UIDs
+			wantSecrets: map[string][]string{ // wantSecrets is a map[node UID] --> list of soft owner UIDs
 				"/v1, Kind=Secret, ns1/foo-ca": { // the ca secret has no explicit OwnerRef to the cluster, so it should be identified as a soft ownership
 					"cluster.x-k8s.io/v1alpha3, Kind=Cluster, ns1/foo",
 				},
@@ -1114,22 +1114,22 @@ func Test_objectGraph_setSoftOwnership(t *testing.T) {
 				t.Fatalf("got = %d secrets, want %d", len(gotSecrets), len(tt.wantSecrets))
 			}
 
-			for _, cluster := range gotSecrets {
-				wantObjects, ok := tt.wantSecrets[string(cluster.identity.UID)]
+			for _, secret := range gotSecrets {
+				wantObjects, ok := tt.wantSecrets[string(secret.identity.UID)]
 				if !ok {
-					t.Fatalf("got = %s, not included in the expected secrect list", cluster.identity.UID)
+					t.Fatalf("got = %s, not included in the expected secrect list", secret.identity.UID)
 				}
 
 				gotObjects := []string{}
-				for softOwners := range cluster.softOwners {
+				for softOwners := range secret.softOwners {
 					gotObjects = append(gotObjects, string(softOwners.identity.UID))
 				}
 
 				sort.Strings(wantObjects)
 				sort.Strings(gotObjects)
 
 				if !reflect.DeepEqual(gotObjects, wantObjects) {
-					t.Fatalf("secret %s, got = %s, expected = %s", cluster.identity.UID, gotObjects, wantObjects)
+					t.Fatalf("secret %s, got = %s, expected = %s", secret.identity.UID, gotObjects, wantObjects)
 				}
 			}
 		})
@@ -1271,7 +1271,7 @@ func Test_objectGraph_setClusterTenants(t *testing.T) {
 				t.Fatal(err)
 			}
 
-			// we want ti check that soft dependent nodes are considered part of the cluster, so we make sure to call SetSoftDependants before SetClusterTenants
+			// we want to check that soft dependent nodes are considered part of the cluster, so we make sure to call SetSoftDependants before SetClusterTenants
 			gb.setSoftOwnership()
 
 			// finally test SetClusterTenants