add unit tests

Author: Yuvaraj Kakaraparthi

util/collections/machine_filters.go

@@ -184,7 +184,7 @@ func ShouldRolloutIfCertificatesExpireWithinMinutes(expiry *int32) Func {
 		if expiry == nil {
 			return false
 		}
-		if machine.Status.CertificatesExpiryDate == nil {
+		if machine == nil || machine.Status.CertificatesExpiryDate == nil {
 			return false
 		}
 		certsExpiryTime := machine.Status.CertificatesExpiryDate.Time

util/collections/machine_filters_test.go

@@ -165,6 +165,49 @@ func TestShouldRolloutAfter(t *testing.T) {
 	})
 }
 
+func TestShouldRolloutIfCertificatesExpireWithinMinutes(t *testing.T) {
+	t.Run("if expiry time is nil it should return false", func(t *testing.T) {
+		g := NewWithT(t)
+		m := &clusterv1.Machine{}
+		g.Expect(collections.ShouldRolloutIfCertificatesExpireWithinMinutes(nil)(m)).To(BeFalse())
+	})
+	t.Run("if machine is nil it should return false", func(t *testing.T) {
+		g := NewWithT(t)
+		g.Expect(collections.ShouldRolloutIfCertificatesExpireWithinMinutes(pointer.Int32(10))(nil)).To(BeFalse())
+	})
+	t.Run("if the machine certificate expiry infromation is not available it should return false", func(t *testing.T) {
+		g := NewWithT(t)
+		m := &clusterv1.Machine{}
+		g.Expect(collections.ShouldRolloutIfCertificatesExpireWithinMinutes(pointer.Int32(10))(m)).To(BeFalse())
+	})
+	t.Run("if the machine certificates are not going to expiry within the expiry time it should return false", func(t *testing.T) {
+		g := NewWithT(t)
+		// TODO: adjust this later after the API is finalized.
+		// Might have to change this to days instead of minutes.
+		expiry := pointer.Int32(10)
+		certificateExpiryTime := time.Now().Add(60 * time.Minute) // certificates will expire in 60 minutes from 'now'.
+		m := &clusterv1.Machine{
+			Status: clusterv1.MachineStatus{
+				CertificatesExpiryDate: &metav1.Time{Time: certificateExpiryTime},
+			},
+		}
+		g.Expect(collections.ShouldRolloutIfCertificatesExpireWithinMinutes(expiry)(m)).To(BeFalse())
+	})
+	t.Run("if machine certificates will expire within the expiry time then it should return true", func(t *testing.T) {
+		g := NewWithT(t)
+		// TODO: adjust this later after the API is finalized.
+		// Might have to change this to days instead of minutes.
+		expiry := pointer.Int32(60)
+		certificateExpiryTime := time.Now().Add(10 * time.Minute) // certificates will expire in 10 minutes from 'now'.
+		m := &clusterv1.Machine{
+			Status: clusterv1.MachineStatus{
+				CertificatesExpiryDate: &metav1.Time{Time: certificateExpiryTime},
+			},
+		}
+		g.Expect(collections.ShouldRolloutIfCertificatesExpireWithinMinutes(expiry)(m)).To(BeTrue())
+	})
+}
+
 func TestHashAnnotationKey(t *testing.T) {
 	t.Run("machine with specified annotation returns true", func(t *testing.T) {
 		g := NewWithT(t)