Rename controller name with - instead of _ (#1149)

Signed-off-by: Vince Prignano <[email protected]>

Author: vincepri

config/rbac/role.yaml

@@ -6,6 +6,24 @@ metadata:
   creationTimestamp: null
   name: manager-role
 rules:
+- apiGroups:
+  - ""
+  resources:
+  - events
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - watch
+- apiGroups:
+  - ""
+  resources:
+  - secrets
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -50,21 +68,3 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - events
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - watch
-- apiGroups:
-  - ""
-  resources:
-  - secrets
-  verbs:
-  - get
-  - list
-  - watch

pkg/controller/cluster/cluster_controller.go

@@ -49,7 +49,7 @@ func newReconciler(mgr manager.Manager, actuator Actuator) reconcile.Reconciler
 // add adds a new Controller to mgr with r as the reconcile.Reconciler
 func add(mgr manager.Manager, r reconcile.Reconciler) error {
 	// Create a new controller
-	c, err := controller.New("cluster_controller", mgr, controller.Options{Reconciler: r})
+	c, err := controller.New("cluster-controller", mgr, controller.Options{Reconciler: r})
 	if err != nil {
 		return err
 	}

pkg/controller/machine/machine_controller.go

@@ -42,7 +42,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/source"
 )
 
-const controllerName = "machine_controller"
+const controllerName = "machine-controller"
 
 // Add creates a new Machine Controller and adds it to the Manager with default RBAC. The Manager will set fields on the Controller
 // and Start it when the Manager is Started.

pkg/controller/machinedeployment/machinedeployment_controller.go

@@ -42,7 +42,7 @@ import (
 )
 
 // controllerName is the name of this controller
-const controllerName = "machinedeployment_controller"
+const controllerName = "machinedeployment-controller"
 
 var (
 	// controllerKind contains the schema.GroupVersionKind for this controller type.

pkg/controller/machineset/machineset_controller.go

@@ -46,7 +46,7 @@ import (
 )
 
 // controllerName is the name of this controller
-const controllerName = "machineset_controller"
+const controllerName = "machineset-controller"
 
 var (
 	// controllerKind contains the schema.GroupVersionKind for this controller type.