Merge pull request #6032 from DiptoChakrabarty/stringer

k8s-ci-robot · web-flow · commit 535219878ced · 2022-02-03T13:32:59.000-08:00
🌱 modify and implement fmt.Stringer with value receiver
diff --git a/api/v1beta1/cluster_types.go b/api/v1beta1/cluster_types.go
@@ -218,8 +218,8 @@ type NetworkRanges struct {
 	CIDRBlocks []string `json:"cidrBlocks"`
 }
 
-func (n *NetworkRanges) String() string {
-	if n == nil {
+func (n NetworkRanges) String() string {
+	if len(n.CIDRBlocks) == 0 {
 		return ""
 	}
 	return strings.Join(n.CIDRBlocks, ",")
diff --git a/test/infrastructure/docker/internal/docker/types/node.go b/test/infrastructure/docker/internal/docker/types/node.go
@@ -58,7 +58,7 @@ func (n *Node) WithStatus(status string) *Node {
 }
 
 // String returns the name of the node.
-func (n *Node) String() string {
+func (n Node) String() string {
 	return n.Name
 }
 

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ type NetworkRanges struct {`
`218`	`218`	CIDRBlocks []string `json:"cidrBlocks"`
`219`	`219`	`}`
`220`	`220`
`221`		`-func (n *NetworkRanges) String() string {`
`222`		`- if n == nil {`
	`221`	`+func (n NetworkRanges) String() string {`
	`222`	`+ if len(n.CIDRBlocks) == 0 {`
`223`	`223`	`return ""`
`224`	`224`	`}`
`225`	`225`	`return strings.Join(n.CIDRBlocks, ",")`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func (n Node) WithStatus(status string) Node {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`// String returns the name of the node.`
`61`		`-func (n *Node) String() string {`
	`61`	`+func (n Node) String() string {`
`62`	`62`	`return n.Name`
`63`	`63`	`}`
`64`	`64`