Merge pull request #3157 from fiunchinho/machinepool-failuredomain

k8s-ci-robot · web-flow · commit 53e98d22ccc1 · 2020-06-17T11:34:05.000-07:00
✨ Add MachinePool support for FailureDomains
diff --git a/config/crd/bases/exp.cluster.x-k8s.io_machinepools.yaml b/config/crd/bases/exp.cluster.x-k8s.io_machinepools.yaml
@@ -55,6 +55,12 @@ spec:
                   to.
                 minLength: 1
                 type: string
+              failureDomains:
+                description: FailureDomains is the list of failure domains this MachinePool
+                  should be attached to.
+                items:
+                  type: string
+                type: array
               minReadySeconds:
                 description: Minimum number of seconds for which a newly created machine
                   instances should be ready. Defaults to 0 (machine instance will
diff --git a/docs/proposals/20190919-machinepool-api.md b/docs/proposals/20190919-machinepool-api.md
@@ -166,6 +166,9 @@ type MachinePoolSpec struct
   - **ClusterName [required]**
     - Type: `string`
     - Description: Name of the Cluster this machine pool belongs to.
+  - **FailureDomains [optional]**
+    - Type: `[]string`
+    - Description: FailureDomains is the list of failure domains this MachinePool should be attached to.
   - **Replicas [optional]**
     - Type: `*int32`
     - Description: Number of desired machine instances. Defaults to 1.
@@ -415,4 +418,3 @@ inconsistent experience across providers.
 10/23/2019: First round of feedback from community
 10/23/2019: Present proposal at a community meeting
 10/31/2019: Open proposal PR
-
diff --git a/exp/api/v1alpha3/machinepool_types.go b/exp/api/v1alpha3/machinepool_types.go
@@ -59,6 +59,9 @@ type MachinePoolSpec struct {
 	// This field must match the provider IDs as seen on the node objects corresponding to a machine pool's machine instances.
 	// +optional
 	ProviderIDList []string `json:"providerIDList,omitempty"`
+
+	// FailureDomains is the list of failure domains this MachinePool should be attached to.
+	FailureDomains []string `json:"failureDomains,omitempty"`
 }
 
 // ANCHOR_END: MachinePoolSpec
diff --git a/exp/api/v1alpha3/zz_generated.deepcopy.go b/exp/api/v1alpha3/zz_generated.deepcopy.go

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,9 @@ type MachinePoolSpec struct {`
`59`	`59`	`// This field must match the provider IDs as seen on the node objects corresponding to a machine pool's machine instances.`
`60`	`60`	`// +optional`
`61`	`61`	ProviderIDList []string `json:"providerIDList,omitempty"`
	`62`	`+`
	`63`	`+ // FailureDomains is the list of failure domains this MachinePool should be attached to.`
	`64`	+ FailureDomains []string `json:"failureDomains,omitempty"`
`62`	`65`	`}`
`63`	`66`
`64`	`67`	`// ANCHOR_END: MachinePoolSpec`