Drop ReconcileError events

sbueringer · sbueringer · commit 550b9dd333c2 · 2024-10-25T16:41:36.000+02:00
Signed-off-by: Stefan Büringer buringerst@vmware.com
diff --git a/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go b/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
@@ -182,7 +182,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
 			log.V(5).Info("Requeuing because connection to the workload cluster is down")
 			return ctrl.Result{RequeueAfter: time.Minute}, nil
 		}
-		r.recorder.Eventf(m, corev1.EventTypeWarning, "ReconcileError", "%v", err)
 
 		// Requeue immediately if any errors occurred
 		return ctrl.Result{}, err
diff --git a/internal/controllers/machineset/machineset_controller.go b/internal/controllers/machineset/machineset_controller.go
@@ -256,7 +256,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (retres ct
 			return ctrl.Result{RequeueAfter: time.Minute}, nil
 		}
 		err = kerr
-		r.recorder.Eventf(s.machineSet, corev1.EventTypeWarning, "ReconcileError", "%v", kerr)
 	}
 	return result, err
 }

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re`
`182`	`182`	`log.V(5).Info("Requeuing because connection to the workload cluster is down")`
`183`	`183`	`return ctrl.Result{RequeueAfter: time.Minute}, nil`
`184`	`184`	`}`
`185`		`- r.recorder.Eventf(m, corev1.EventTypeWarning, "ReconcileError", "%v", err)`
`186`	`185`
`187`	`186`	`// Requeue immediately if any errors occurred`
`188`	`187`	`return ctrl.Result{}, err`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (retres ct`
`256`	`256`	`return ctrl.Result{RequeueAfter: time.Minute}, nil`
`257`	`257`	`}`
`258`	`258`	`err = kerr`
`259`		`- r.recorder.Eventf(s.machineSet, corev1.EventTypeWarning, "ReconcileError", "%v", kerr)`
`260`	`259`	`}`
`261`	`260`	`return result, err`
`262`	`261`	`}`