Skip to content

Commit 6941e8c

Browse files
authored
Merge pull request #10711 from sbueringer/pr-fix-kcp-flakes
🐛 Fix some KCP unit test flakes
2 parents ebdda34 + 77ac940 commit 6941e8c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

controlplane/kubeadm/internal/controllers/controller_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1226,7 +1226,7 @@ func TestReconcileInitializeControlPlane(t *testing.T) {
12261226
},
12271227
},
12281228
}
1229-
g.Expect(env.Create(ctx, genericInfrastructureMachineTemplate)).To(Succeed())
1229+
g.Expect(env.CreateAndWait(ctx, genericInfrastructureMachineTemplate)).To(Succeed())
12301230

12311231
kcp := &controlplanev1.KubeadmControlPlane{
12321232
ObjectMeta: metav1.ObjectMeta{

controlplane/kubeadm/internal/controllers/scale_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func TestKubeadmControlPlaneReconciler_initializeControlPlane(t *testing.T) {
6262
defer teardown(t, g, namespace)
6363

6464
cluster, kcp, genericInfrastructureMachineTemplate := createClusterWithControlPlane(namespace.Name)
65-
g.Expect(env.Create(ctx, genericInfrastructureMachineTemplate, client.FieldOwner("manager"))).To(Succeed())
65+
g.Expect(env.CreateAndWait(ctx, genericInfrastructureMachineTemplate, client.FieldOwner("manager"))).To(Succeed())
6666
kcp.UID = types.UID(util.RandomString(10))
6767

6868
r := &KubeadmControlPlaneReconciler{
@@ -128,7 +128,7 @@ func TestKubeadmControlPlaneReconciler_scaleUpControlPlane(t *testing.T) {
128128
defer teardown(t, g, namespace)
129129

130130
cluster, kcp, genericInfrastructureMachineTemplate := createClusterWithControlPlane(namespace.Name)
131-
g.Expect(env.Create(ctx, genericInfrastructureMachineTemplate, client.FieldOwner("manager"))).To(Succeed())
131+
g.Expect(env.CreateAndWait(ctx, genericInfrastructureMachineTemplate, client.FieldOwner("manager"))).To(Succeed())
132132
kcp.UID = types.UID(util.RandomString(10))
133133
setKCPHealthy(kcp)
134134

0 commit comments

Comments
 (0)