Skip to content

Commit 6bb820a

Browse files
committed
enxebre feedback
1 parent 09c0d35 commit 6bb820a

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

docs/proposals/20220725-managed-kubernetes.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ So that I can eliminate the responsibility of owning and SREing the Control Plan
234234
- CRDs
235235
- GCPManagedControlPlane, GCPManagedCluster - provision GKE cluster
236236
- GCPManagedMachinePool - corresponds to managed node pool
237-
- Support falvor
237+
- Support flavor
238238
- GCPManagedControlPlane + GCPManagedCluster with GCPManagedMachinePool
239239

240240
### Managed Kubernetes API Design Approaches
@@ -342,7 +342,7 @@ type GCPManagedControlPlaneSpec struct {
342342

343343
**Cons**
344344

345-
- If the configuration/functionality related to the base infrastructure are included then we have mixed concerns of the APPI type.
345+
- If the configuration/functionality related to the base infrastructure are included then we have mixed concerns of the API type.
346346

347347
#### Option 3: Two kinds with a Managed Control Plane and Managed Infra Cluster with Better Separation of Responsibilities
348348

docs/proposals/20230407-managed-k8s-capi-contract-changes.md

+9-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,15 @@ The following terms will be used in this document.
111111

112112
## Summary
113113

114-
We propose to make provider `<Infra>Cluster` resources optional in order to better represent Managed Kubernetes scenarios where all _Kubernetes Cluster Infrastructure_ is managed by the service provider, and not by Cluster API. In order to support that, we propose that the API Server endpoint reference can also originate from the `<Infra>ControlPlane` resource, and not the `<Infra>Cluster` resource. These changes will introduce two new possible implementation options for providers implementing Managed Kubernetes in Cluster API:
114+
We propose to relax the `<Infra>Cluster` resource Cluster API contract so that the `<Infra>ControlPlane` resource may authoritatively express the control plane endpoint in order to better represent real workflows and reduce the complexity for provider implementers.
115+
116+
By relaxing the `<Infra>Cluster` contract with respect to the control plane endpoint we can also now provide the opportunity to make the `<Infra>Cluster` resource fully optional. This additional flexibility will allow Cluster API providers to better represent various Managed Kubernetes service offerings:
117+
118+
- Cluster Infra is entirely abstracted away from the Managed Kubernetes user
119+
- Cluster Infra is exposed to the Managed Kubernetes user, but managed by the Managed Kubernetes service
120+
- Cluster Infra is provided by the user (BYO) to support the Managed Kubernetes service
121+
122+
In order to support the above, we propose that the API Server endpoint reference can also originate from the `<Infra>ControlPlane` resource, and not the `<Infra>Cluster` resource. These changes will introduce two new possible implementation options for providers implementing Managed Kubernetes in Cluster API:
115123

116124
1. A Managed Kubernetes cluster solution whose configuration surface area is expressed exclusively in a `<Infra>ControlPlane` resource (no `<Infra>Cluster` resource).
117125
2. A Managed Kubernetes cluster solution whose configuration surface area comprises both a `<Infra>Cluster` and a `<Infra>ControlPlane` resource, with `<Infra>ControlPlane` being solely responsible for configuring the API Server endpoint (instead of the API Server endpoint being configured via the `<Infra>Cluster`).

0 commit comments

Comments
 (0)