Update KAL config based on review feedback

Author: JoelSpeed

.golangci-kal.yml

@@ -22,7 +22,10 @@ linters-settings:
           - "jsontags" # Ensure every field has a json tag.
           - "maxlength" # Ensure all strings and arrays have maximum lengths/maximum items.
           - "nobools" # Bools do not evolve over time, should use enums instead.
-          - "nophase" # Phase fields are discouraged by the Kube API conventions, use conditions instead.
+          # Per discussion in July 2024, we are keeping phase fields for now.
+          # See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508
+          # and https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685919394.
+          # - "nophase" # Phase fields are discouraged by the Kube API conventions, use conditions instead.
           - "optionalorrequired" # Every field should be marked as `+optional` or `+required`.
           - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
           - "statussubresource" # All root objects that have a `status` field should have a status subresource.
@@ -46,6 +49,7 @@ issues:
     - "vendored_openapi\\.go$"
     # We don't want to invest time to fix new linter findings in old API types.
     - "internal/apis/.*"
+    - ".*_test.go"  # Exclude test files.
   max-same-issues: 0
   max-issues-per-linter: 0
   exclude-rules: