Remove message from Runtime SDK FailureResponses

Signed-off-by: killianmuldoon <[email protected]>

Author: killianmuldoon

internal/runtime/client/client.go

@@ -142,7 +142,9 @@ func (c *client) Discover(ctx context.Context, extensionConfig *runtimev1.Extens
 
 	// Check to see if the response is a failure and handle the failure accordingly.
 	if response.GetStatus() == runtimehooksv1.ResponseStatusFailure {
-		return nil, errors.Errorf("failed to discover extension %q: got failure response with message %q", extensionConfig.Name, response.GetMessage())
+		log.Info(fmt.Sprintf("failed to discover extension %q: got failure response with message %v", extensionConfig.Name, response.GetMessage()))
+		// Don't add the message to the error as it is may be unique causing too many reconciliations. Ref: https://github.com/kubernetes-sigs/cluster-api/issues/6921
+		return nil, errors.Errorf("failed to discover extension %q: got failure response", extensionConfig.Name)
 	}
 
 	// Check to see if the response is valid.
@@ -364,8 +366,9 @@ func (c *client) CallExtension(ctx context.Context, hook runtimecatalog.Hook, fo
 
 	// If the received response is a failure then return an error.
 	if response.GetStatus() == runtimehooksv1.ResponseStatusFailure {
-		log.Error(err, "extension handler returned a failure response")
-		return errors.Errorf("failed to call extension handler %q: got failure response with message %q", name, response.GetMessage())
+		log.Info(fmt.Sprintf("failed to call extension handler %q: got failure response with message %v", name, response.GetMessage()))
+		// Don't add the message to the error as it is may be unique causing too many reconciliations. Ref: https://github.com/kubernetes-sigs/cluster-api/issues/6921
+		return errors.Errorf("failed to call extension handler %q: got failure response", name)
 	}
 
 	if retryResponse, ok := response.(runtimehooksv1.RetryResponseObject); ok && retryResponse.GetRetryAfterSeconds() != 0 {

internal/runtime/utils/error.go

@@ -0,0 +1,25 @@
+package utils
+
+import "github.com/pkg/errors"
+
+type VariableNotFoundErr struct {
+	err error
+}
+
+func variableNotFoundError(err error) VariableNotFoundErr {
+	return VariableNotFoundErr{
+		err: err,
+	}
+}
+
+func (v VariableNotFoundErr) Error() string {
+	return v.err.Error()
+}
+
+func (VariableNotFoundErr) Cause() error {
+	return errors.New("variable not found")
+}
+
+func IsVariableNotFoundErr(e error) bool {
+	(errors.As(e))
+}