address comments

Author: fabriziopandini

Makefile

@@ -189,8 +189,7 @@ generate-go-core: $(CONTROLLER_GEN) $(CONVERSION_GEN)
 	$(CONTROLLER_GEN) \
 		object:headerFile=./hack/boilerplate/boilerplate.generatego.txt \
 		paths=./api/... \
-		paths=./cmd/clusterctl/api/... \
-		paths=./cmd/clusterctl/pkg/internal/test/providers/...
+		paths=./cmd/clusterctl/...
 	$(CONVERSION_GEN) \
 		--input-dirs=./api/v1alpha2 \
 		--output-file-base=zz_generated.conversion \

cmd/clusterctl/pkg/internal/test/fake_objects.go

@@ -742,7 +742,7 @@ func (f *FakeMachine) Objs(cluster *clusterv1.Cluster, generateCerts bool, machi
 			// Labels: cluster.x-k8s.io/cluster-name=cluster, Added by the machine controller (see below) -- RECONCILED
 		},
 		Status: fakebootstrap.DummyBootstrapConfigStatus{
-			DataSecretName: bootstrapDataSecretName,
+			DataSecretName: &bootstrapDataSecretName,
 		},
 	}
 
@@ -880,7 +880,10 @@ func (f *FakeMachine) Objs(cluster *clusterv1.Cluster, generateCerts bool, machi
 // setUID assigns a UID to the object, so test objects are uniquely identified.
 // NB. In order to make debugging easier we are using a human readable, deterministic string (instead of a random UID).
 func setUID(obj runtime.Object) {
-	accessor, _ := meta.Accessor(obj)
+	accessor, err := meta.Accessor(obj)
+	if err != nil {
+		panic(fmt.Sprintf("failde to get accessor for test object: %v", err))
+	}
 	uid := fmt.Sprintf("%s, %s/%s", obj.GetObjectKind().GroupVersionKind().String(), accessor.GetNamespace(), accessor.GetName())
 	accessor.SetUID(types.UID(uid))
 }
@@ -893,12 +896,12 @@ func FakeCustomResourceDefinition(group string, kind string, versions ...string)
 			APIVersion: "CustomResourceDefinition",
 		},
 		ObjectMeta: metav1.ObjectMeta{
-			Name: fmt.Sprintf("%s.%s", strings.ToLower(kind), group),
+			Name: fmt.Sprintf("%s.%s", strings.ToLower(kind), group), //NB. this technically should use plural(kind), but for the sake of test what really matters is to generate a unique name
 			Labels: map[string]string{
 				clusterctlv1.ClusterctlLabelName: "",
 			},
 		},
-		Spec: apiextensionslv1.CustomResourceDefinitionSpec{
+		Spec: apiextensionslv1.CustomResourceDefinitionSpec{ //NB. the spec contains only what is strictly required by the move test
 			Group: group,
 			Names: apiextensionslv1.CustomResourceDefinitionNames{
 				Kind: kind,

cmd/clusterctl/pkg/internal/test/providers/bootstrap/dummy_types.go

@@ -25,7 +25,7 @@ import (
 
 type DummyBootstrapConfigStatus struct {
 	// +optional
-	DataSecretName string `json:"dataSecretName,omitempty"` //TODO: capire perche con *string fallisce...
+	DataSecretName *string `json:"dataSecretName,omitempty"`
 }
 
 // +kubebuilder:object:root=true

cmd/clusterctl/pkg/internal/test/providers/bootstrap/zz_generated.deepcopy.go

@@ -15,7 +15,7 @@ limitations under the License.
 */
 
 // +kubebuilder:object:generate=true
-// +groupName=infrastructure.clusterctl.cluster.x-k8s.io
+// +groupName=infrastructure.cluster.x-k8s.io
 package infrastructure
 
 import (