add todo

chrischdi · chrischdi · commit 9f739949794c · 2024-10-02T16:30:48.000+02:00
diff --git a/internal/controllers/machine/machine_controller.go b/internal/controllers/machine/machine_controller.go
@@ -1118,6 +1118,8 @@ func (w *attachedVolumeHelper) ignore(pv *corev1.PersistentVolume) {
 func getPersistentVolumeClaimsFromIgnoredPods(ctx context.Context, remoteClient client.Client, nodeName string) (sets.Set[string], error) {
 	drainHelper := drain.Helper{
 		Client: remoteClient,
+		// TODO(chrischdi) we might have to set this to not ignore volumes for pods pending deletion
+		SkipWaitForDeleteTimeoutSeconds: 99999999,
 	}
 
 	pods, err := drainHelper.GetPodsForEviction(ctx, nodeName)

Original file line number	Diff line number	Diff line change
`@@ -1118,6 +1118,8 @@ func (w attachedVolumeHelper) ignore(pv corev1.PersistentVolume) {`
`1118`	`1118`	`func getPersistentVolumeClaimsFromIgnoredPods(ctx context.Context, remoteClient client.Client, nodeName string) (sets.Set[string], error) {`
`1119`	`1119`	`drainHelper := drain.Helper{`
`1120`	`1120`	`Client: remoteClient,`
	`1121`	`+ // TODO(chrischdi) we might have to set this to not ignore volumes for pods pending deletion`
	`1122`	`+ SkipWaitForDeleteTimeoutSeconds: 99999999,`
`1121`	`1123`	`}`
`1122`	`1124`
`1123`	`1125`	`pods, err := drainHelper.GetPodsForEviction(ctx, nodeName)`