Skip to content

Commit c5508cf

Browse files
committed
Address review comments
1 parent b7c8d8e commit c5508cf

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

test/e2e/clusterctl_upgrade_test.go

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,13 @@ var (
3737
providerDockerPrefix = "docker:v%s"
3838
)
3939

40-
var _ = Describe("When testing clusterctl upgrades (v0.3=>v1.6=>current)", func() {
40+
var _ = Describe("When testing clusterctl upgrades (v0.3=>v1.5=>current)", func() {
41+
// We are testing v0.3=>v1.5=>current to ensure that old entries with v1alpha3 in managed files do not cause issues
42+
// as described in https://github.com/kubernetes-sigs/cluster-api/issues/10051.
43+
// NOTE: The combination of v0.3=>v1.5=>current allows us to verify this without being forced to upgrade
44+
// the management cluster in the middle of the test as all 3 versions are ~ compatible with the same mgmt and workload Kubernetes versions.
45+
// Additionally, clusterctl v1.5 still allows the upgrade of management clusters from v1alpha3 (v1.6 doesn't).
46+
4147
// Get v0.3 latest stable release
4248
version03 := "0.3"
4349
stableRelease03, err := GetStableReleaseOfMinor(ctx, version03)
@@ -105,6 +111,12 @@ var _ = Describe("When testing clusterctl upgrades (v0.3=>v1.6=>current)", func(
105111
})
106112

107113
var _ = Describe("When testing clusterctl upgrades (v0.4=>v1.6=>current)", func() {
114+
// We are testing v0.4=>v1.6=>current to ensure that old entries with v1alpha4 in managed files do not cause issues
115+
// as described in https://github.com/kubernetes-sigs/cluster-api/issues/10051.
116+
// NOTE: The combination of v0.4=>v1.6=>current allows us to verify this without being forced to upgrade
117+
// the management cluster in the middle of the test as all 3 versions are ~ compatible with the same mgmt and workload Kubernetes versions.
118+
// Additionally, clusterctl v1.6 still allows the upgrade of management clusters from v1alpha4 (v1.7 doesn't).
119+
108120
// Get v0.4 latest stable release
109121
version04 := "0.4"
110122
stableRelease04, err := GetStableReleaseOfMinor(ctx, version04)

0 commit comments

Comments
 (0)