Address more comments

Author: fabriziopandini

internal/contract/controlplane.go

@@ -241,7 +241,7 @@ func (c *ControlPlaneContract) IsUpgrading(obj *unstructured.Unstructured) (bool
 // - spec.replicas != status.replicas.
 // - spec.replicas != status.upToDateReplicas.
 // - spec.replicas != status.readyReplicas.
-// - status.unavailableReplicas > 0.
+// - spec.replicas != status.availableReplicas.
 // NOTE: this function is used only in E2E tests.
 func (c *ControlPlaneContract) IsScaling(obj *unstructured.Unstructured, contractVersion string) (bool, error) {
 	desiredReplicas, err := c.Replicas().Get(obj)

internal/controllers/topology/cluster/conditions_test.go

@@ -830,9 +830,9 @@ func TestReconcileTopologyReconciledCondition(t *testing.T) {
 								WithVersion("v1.22.0").
 								WithStatus(clusterv1.MachineDeploymentStatus{
 									Replicas:          int32(1),
-									ReadyReplicas:     ptr.To[int32](2),
-									UpToDateReplicas:  ptr.To[int32](2),
-									AvailableReplicas: ptr.To[int32](2),
+									ReadyReplicas:     ptr.To[int32](1),
+									UpToDateReplicas:  ptr.To[int32](1),
+									AvailableReplicas: ptr.To[int32](1),
 								}).
 								Build(),
 						},