capd: don't add host ports to exposed ports of containers

schrej · schrej · commit cb74915609d4 · 2024-05-21T19:52:02.000+02:00
This fixes an issue when running capd with podmans docker compatibility mode. And it's also incorrect in general.
diff --git a/test/infrastructure/container/docker.go b/test/infrastructure/container/docker.go
@@ -727,7 +727,6 @@ func configurePortMappings(portMappings []PortMapping, config *dockercontainer.C
 		}
 		hostConfig.PortBindings[port] = append(hostConfig.PortBindings[port], mapping)
 		exposedPorts[port] = struct{}{}
-		exposedPorts[nat.Port(fmt.Sprintf("%d/tcp", pm.HostPort))] = struct{}{}
 	}
 
 	config.ExposedPorts = exposedPorts

Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,6 @@ func configurePortMappings(portMappings []PortMapping, config *dockercontainer.C`
`727`	`727`	`}`
`728`	`728`	`hostConfig.PortBindings[port] = append(hostConfig.PortBindings[port], mapping)`
`729`	`729`	`exposedPorts[port] = struct{}{}`
`730`		`- exposedPorts[nat.Port(fmt.Sprintf("%d/tcp", pm.HostPort))] = struct{}{}`
`731`	`730`	`}`
`732`	`731`
`733`	`732`	`config.ExposedPorts = exposedPorts`