WIP: Implement pausing for machine controller

Author: theobarberbany

internal/controllers/machine/machine_controller.go

@@ -183,12 +183,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
 			m.Spec.ClusterName, m.Name, m.Namespace)
 	}
 
-	// Return early if the object or Cluster is paused.
-	if annotations.IsPaused(cluster, m) {
-		log.Info("Reconciliation is paused for this object")
-		return ctrl.Result{}, nil
-	}
-
 	// Initialize the patch helper
 	patchHelper, err := patch.NewHelper(m, r.Client)
 	if err != nil {
@@ -209,6 +203,16 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
 		}
 	}()
 
+	// Return early and set the paused condition to True if the object or Cluster
+	// is paused.
+	if annotations.IsPaused(cluster, m) {
+		log.Info("Reconciliation is paused for this object")
+		conditions.MarkTrue(m, clusterv1.PausedCondition)
+		return ctrl.Result{}, nil
+	}
+
+	conditions.MarkFalse(m, clusterv1.PausedCondition, clusterv1.ResourceNotPausedReason, clusterv1.ConditionSeverityInfo, "Resource is operating as expected")
+
 	// Reconcile labels.
 	if m.Labels == nil {
 		m.Labels = make(map[string]string)
@@ -275,6 +279,7 @@ func patchMachine(ctx context.Context, patchHelper *patch.Helper, machine *clust
 			clusterv1.ReadyCondition,
 			clusterv1.BootstrapReadyCondition,
 			clusterv1.InfrastructureReadyCondition,
+			clusterv1.PausedCondition,
 			clusterv1.DrainingSucceededCondition,
 			clusterv1.MachineHealthCheckSucceededCondition,
 			clusterv1.MachineOwnerRemediatedCondition,

internal/controllers/machine/machine_controller_test.go

@@ -1050,6 +1050,19 @@ func TestMachineConditions(t *testing.T) {
 				conditions.TrueCondition(clusterv1.ReadyCondition),
 			},
 		},
+		{
+			name:           "paused initialises false",
+			infraReady:     true,
+			bootstrapReady: true,
+			beforeFunc: func(_, _ *unstructured.Unstructured, m *clusterv1.Machine) {
+				// since these conditions are set by an external controller
+				conditions.MarkTrue(m, clusterv1.MachineHealthCheckSucceededCondition)
+				conditions.MarkTrue(m, clusterv1.MachineOwnerRemediatedCondition)
+			},
+			conditionsToAssert: []*clusterv1.Condition{
+				conditions.FalseCondition(clusterv1.PausedCondition, "ResourceNotPaused", clusterv1.ConditionSeverityInfo, "Resource is operating as expected"),
+			},
+		},
 		{
 			name:           "infra condition consumes reason from the infra config",
 			infraReady:     false,
@@ -1210,6 +1223,12 @@ func TestMachineConditions(t *testing.T) {
 			m = &clusterv1.Machine{}
 			g.Expect(r.Client.Get(ctx, client.ObjectKeyFromObject(&machine), m)).ToNot(HaveOccurred())
 
+			if tt.name == "paused initialises false" {
+				fmt.Printf("-----------\n-----------\n\n\n\n")
+				fmt.Printf("machine status: %+v\n\n", m.Status)
+				fmt.Printf("-----------\n-----------\n\n\n\n")
+			}
+
 			assertConditions(t, m, tt.conditionsToAssert...)
 		})
 	}