Merge pull request #3171 from fabriziopandini/fix-test-NewFakeClientWithScheme

🌱 fix test/helpers.NewFakeClientWithScheme

Author: k8s-ci-robot

test/helpers/client.go

@@ -25,20 +25,25 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"
 )
 
-// NewFakeClientWithScheme creates a new fake client with the given scheme
-// for testing.
+// NewFakeClientWithScheme creates a new fake client with the given scheme for testing.
 // You can choose to initialize it with a slice of runtime.Object; all the objects with be given
-// a fake ResourceVersion="1" so it will be possible to use optimistic lock when patching conditions.
+// a fake ResourceVersion="1" so it will be possible to use optimistic lock.
 func NewFakeClientWithScheme(clientScheme *runtime.Scheme, initObjs ...runtime.Object) client.Client {
-	for _, obj := range initObjs {
-		accessor, err := meta.Accessor(obj)
+	// NOTE: for consistency with the NewFakeClientWithScheme func in controller runtime, this func
+	// should not have side effects on initObjs. So it creates a copy of each object and
+	// set the resourceVersion on the copy only.
+	initObjsWithResourceVersion := make([]runtime.Object, len(initObjs))
+	for i := range initObjs {
+		objsWithResourceVersion := initObjs[i].DeepCopyObject()
+		accessor, err := meta.Accessor(objsWithResourceVersion)
 		if err != nil {
 			panic(fmt.Errorf("failed to get accessor for object: %v", err))
 		}
 
 		if accessor.GetResourceVersion() == "" {
 			accessor.SetResourceVersion("1")
 		}
+		initObjsWithResourceVersion[i] = objsWithResourceVersion
 	}
-	return fake.NewFakeClientWithScheme(clientScheme, initObjs...)
+	return fake.NewFakeClientWithScheme(clientScheme, initObjsWithResourceVersion...)
 }