address comments

Author: fabriziopandini

cmd/clusterctl/pkg/client/repository/client.go

@@ -166,14 +166,21 @@ func getLocalOverride(provider config.Provider, version, path string) ([]byte, e
 	homeFolder := filepath.Join(homedir.HomeDir(), config.ConfigFolder)
 	overridePath := filepath.Join(homeFolder, overrideFolder, provider.Name(), version, path)
 
-	// it the local override exists use it, otherwise read from the repository
-	if _, err := os.Stat(overridePath); err == nil {
+	// it the local override exists, use it
+	_, err := os.Stat(overridePath)
+	if err == nil {
 		content, err := ioutil.ReadFile(overridePath)
 		if err != nil {
 			return nil, errors.Wrapf(err, "failed to read local override for %s/%s/%s", provider.Name(), version, path)
 		}
 		return content, nil
 	}
 
-	return nil, nil
+	// it the local override does not exists, return (so files from the provider's repository could be used)
+	if os.IsNotExist(err) {
+		return nil, nil
+	}
+
+	// blocks for any other error
+	return nil, err
 }

cmd/clusterctl/pkg/client/repository/components_client.go

@@ -64,7 +64,7 @@ func (f *componentsClient) Get(version, targetNamespace, watchingNamespace strin
 	if file == nil {
 		file, err = f.repository.GetFile(version, path)
 		if err != nil {
-			return nil, errors.Wrapf(err, "failed to read %q from the repository for provider %q", path, f.provider.Name())
+			return nil, errors.Wrapf(err, "failed to read %q from provider's repository %q", path, f.provider.Name())
 		}
 	}