Fix linting issues

Author: theobarberbany

api/v1beta1/condition_consts.go

@@ -24,9 +24,6 @@ const (
 	ReadyCondition ConditionType = "Ready"
 
 	// PausedCondition defines the Paused condition type that summarizes the operational state of a Cluster API object.
-
-	// TODO: I've noticed we have controller specific conditions. I'm not sure if
-	// I want to have a shared condition, or many controller specific conditions. 🤔
 	PausedCondition ConditionType = "Paused"
 )
 

controlplane/kubeadm/internal/controllers/controller_test.go

@@ -2378,7 +2378,6 @@ func TestReconcilePausedCondition(t *testing.T) {
 		// The condition is set to true
 		return conditions.IsTrue(kcp, clusterv1.PausedCondition)
 	}, timeout).Should(BeTrue())
-
 }
 
 // test utils.

internal/controllers/machine/machine_controller_test.go

@@ -2643,8 +2643,7 @@ func TestPauseConditionReconcile(t *testing.T) {
 	g.Expect(unstructured.SetNestedField(infraMachine.Object, true, "status", "ready")).To(Succeed())
 	g.Expect(env.Status().Patch(ctx, infraMachine, infraMachinePatch)).To(Succeed())
 
-	// The cluster starts paused, so the machine machine should have a Paused:
-	// true condition
+	// Cluster starts paused, so the machine should have a Paused: true condition
 	g.Eventually(func() bool {
 		if err := env.Get(ctx, key, machine); err != nil {
 			return false

util/predicates/cluster_predicates.go

@@ -168,6 +168,8 @@ func ClusterUnpaused(logger logr.Logger) predicate.Funcs {
 	return Any(log, ClusterCreateNotPaused(log), ClusterUpdateUnpaused(log))
 }
 
+// ClusterCreateUpdateEvent returns a predicate that returns true on any cluster creation event, or any update event where the cluster is paused or unpaused. This is to allow updating of paused conditions on CAPI objects.
+// TODO: Look and see if there's a better way to do this. I'm pretty sure there is.
 func ClusterCreateUpdateEvent(logger logr.Logger) predicate.Funcs {
 	return predicate.Funcs{
 		UpdateFunc: func(e event.UpdateEvent) bool {
@@ -203,7 +205,8 @@ func ClusterCreateUpdateEvent(logger logr.Logger) predicate.Funcs {
 				return false
 			}
 			log = log.WithValues("Cluster", klog.KObj(c))
-
+			log.V(4).Info(`Cluster created, allowing further processing regardless of
+			.spec.paused to update conditions`)
 			return true
 		},
 		DeleteFunc:  func(event.DeleteEvent) bool { return false },