Merge pull request #11329 from AndiDog/node-refs-log

k8s-ci-robot · web-flow · commit f1b11741f3d6 · 2024-10-23T10:14:58.000+01:00
🌱 Improve log when not enough replicas are ready or referenced
diff --git a/exp/internal/controllers/machinepool_controller_noderef.go b/exp/internal/controllers/machinepool_controller_noderef.go
@@ -116,7 +116,7 @@ func (r *MachinePoolReconciler) reconcileNodeRefs(ctx context.Context, s *scope)
 	}
 
 	if mp.Status.Replicas != mp.Status.ReadyReplicas || len(nodeRefsResult.references) != int(mp.Status.ReadyReplicas) {
-		log.Info("NodeRefs != ReadyReplicas", "nodeRefs", len(nodeRefsResult.references), "readyReplicas", mp.Status.ReadyReplicas)
+		log.Info("Not enough ready replicas or node references", "nodeRefs", len(nodeRefsResult.references), "readyReplicas", mp.Status.ReadyReplicas, "replicas", mp.Status.Replicas)
 		conditions.MarkFalse(mp, expv1.ReplicasReadyCondition, expv1.WaitingForReplicasReadyReason, clusterv1.ConditionSeverityInfo, "")
 		return ctrl.Result{RequeueAfter: 30 * time.Second}, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ func (r MachinePoolReconciler) reconcileNodeRefs(ctx context.Context, s scope)`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`if mp.Status.Replicas != mp.Status.ReadyReplicas \|\| len(nodeRefsResult.references) != int(mp.Status.ReadyReplicas) {`
`119`		`- log.Info("NodeRefs != ReadyReplicas", "nodeRefs", len(nodeRefsResult.references), "readyReplicas", mp.Status.ReadyReplicas)`
	`119`	`+ log.Info("Not enough ready replicas or node references", "nodeRefs", len(nodeRefsResult.references), "readyReplicas", mp.Status.ReadyReplicas, "replicas", mp.Status.Replicas)`
`120`	`120`	`conditions.MarkFalse(mp, expv1.ReplicasReadyCondition, expv1.WaitingForReplicasReadyReason, clusterv1.ConditionSeverityInfo, "")`
`121`	`121`	`return ctrl.Result{RequeueAfter: 30 * time.Second}, nil`
`122`	`122`	`}`