Remove lint exclude for directory permissions

This removes the linting exclusion for warning about directories being
created with too open of permissions. We only had one instance of a
directory being created with 755. This does not appear to be needed.
Permissions changed to 750 and golangci-lint exclusion for the warning
is now removed.

Signed-off-by: Sean McGinnis <[email protected]>

Author: stmcginnis

.golangci.yml

@@ -74,7 +74,6 @@ issues:
   # The following are being worked on to remove their exclusion. This list should be reduced or go away all together over time.
   # If it is decided they will not be addressed they should be moved above this comment.
   - Subprocess launch(ed with variable|ing should be audited)
-  - (Expect directory permissions to be 0750 or less|Expect file permissions to be 0600 or less)
   - (G104|G307)
   exclude-rules:
   - linters:

cmd/clusterctl/client/repository/repository_local_test.go

@@ -137,7 +137,7 @@ func createLocalTestProviderFile(t *testing.T, tmpDir, path, msg string) string
 
 	dst := filepath.Join(tmpDir, path)
 	// Create all directories in the standard layout
-	g.Expect(os.MkdirAll(filepath.Dir(dst), 0755)).To(Succeed())
+	g.Expect(os.MkdirAll(filepath.Dir(dst), 0750)).To(Succeed())
 	g.Expect(os.WriteFile(dst, []byte(msg), 0600)).To(Succeed())
 
 	return dst