Skip to content

Commit fa6bda0

Browse files
authored
Merge pull request #10938 from chrischdi/pr-release-1-6-ignore-ip6tables
🐛 [release-1.6] docker: ignore kubeadm preflight check for FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables
2 parents fd5e25e + b1d5dd3 commit fa6bda0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/infrastructure/docker/internal/provisioning/cloudinit/runcmd.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (a *runCmd) Commands() ([]provisioning.Cmd, error) {
5656
}
5757

5858
// ignorePreflightErrors are preflight errors that fail in CAPD and thus we have to ignore them.
59-
const ignorePreflightErrors = "SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables"
59+
const ignorePreflightErrors = "SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables,FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables"
6060

6161
func hackKubeadmIgnoreErrors(c provisioning.Cmd) provisioning.Cmd {
6262
// case kubeadm commands are defined as a string

test/infrastructure/docker/internal/provisioning/cloudinit/runcmd_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func TestRunCmdRun(t *testing.T) {
7171
},
7272
},
7373
expectedCmds: []provisioning.Cmd{
74-
{Cmd: "/bin/sh", Args: []string{"-c", "kubeadm init --ignore-preflight-errors=SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables --config /run/kubeadm/kubeadm.yaml"}},
74+
{Cmd: "/bin/sh", Args: []string{"-c", "kubeadm init --ignore-preflight-errors=SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables,FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables --config /run/kubeadm/kubeadm.yaml"}},
7575
},
7676
},
7777
}
@@ -101,11 +101,11 @@ runcmd:
101101

102102
r.Cmds[0] = hackKubeadmIgnoreErrors(r.Cmds[0])
103103

104-
expected0 := provisioning.Cmd{Cmd: "/bin/sh", Args: []string{"-c", "kubeadm init --ignore-preflight-errors=SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables --config=/run/kubeadm/kubeadm.yaml"}}
104+
expected0 := provisioning.Cmd{Cmd: "/bin/sh", Args: []string{"-c", "kubeadm init --ignore-preflight-errors=SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables,FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables --config=/run/kubeadm/kubeadm.yaml"}}
105105
g.Expect(r.Cmds[0]).To(BeComparableTo(expected0))
106106

107107
r.Cmds[1] = hackKubeadmIgnoreErrors(r.Cmds[1])
108108

109-
expected1 := provisioning.Cmd{Cmd: "kubeadm", Args: []string{"join", "--ignore-preflight-errors=SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables", "--config=/run/kubeadm/kubeadm-controlplane-join-config.yaml"}}
109+
expected1 := provisioning.Cmd{Cmd: "kubeadm", Args: []string{"join", "--ignore-preflight-errors=SystemVerification,Swap,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables,FileContent--proc-sys-net-bridge-bridge-nf-call-ip6tables", "--config=/run/kubeadm/kubeadm-controlplane-join-config.yaml"}}
110110
g.Expect(r.Cmds[1]).To(BeComparableTo(expected1))
111111
}

0 commit comments

Comments
 (0)