Skip to content

Avoid patching Cluster object in Machine Controller #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vincepri opened this issue Aug 28, 2019 · 3 comments · Fixed by #1356
Closed

Avoid patching Cluster object in Machine Controller #1333

vincepri opened this issue Aug 28, 2019 · 3 comments · Fixed by #1356
Assignees
@tahsinrahman
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v0.2.x

Comments

@vincepri
Copy link
Member

/kind cleanup

Describe the solution you'd like
Currently, when the Machine controller sees the first control plane machine with a reference, we call the MachineReconciler's reconcileClusterStatus method to set the Status.ControlPlaneInitialized field to true.

Long term, this logic should move to the Cluster reconciler, which will need to watch and retrieve its Machines before being able to set the field.
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 28, 2019
@vincepri vincepri added this to the v0.2.x (v1alpha2) milestone Aug 28, 2019
@vincepri vincepri mentioned this issue Aug 28, 2019
Merged
@tahsinrahman
Copy link
Contributor

@vincepri if you're not working on this, can i take this? thanks!

@vincepri
Copy link
Member Author

Go for it!

@tahsinrahman
Copy link
Contributor

tahsinrahman commented Aug 31, 2019 •
edited
Loading

/assign
/lifecycle active

@tahsinrahman tahsinrahman mentioned this issue Aug 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tahsinrahman tahsinrahman

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.2.x
Development

Successfully merging a pull request may close this issue.

🏃 Update status.controlPlaneInitialized from cluster controller tahsinrahman/cluster-api
3 participants
@vincepri @tahsinrahman @k8s-ci-robot