Skip to content

Support updating Status.InfrastructureReady on Cluster #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vincepri opened this issue Oct 25, 2019 · 4 comments · Fixed by #1854
Closed

Support updating Status.InfrastructureReady on Cluster #1657

vincepri opened this issue Oct 25, 2019 · 4 comments · Fixed by #1854
Assignees
@vincepri
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.3.0

Comments

@vincepri
Copy link
Member

vincepri commented Oct 25, 2019 •
edited
Loading

Detailed Description

Follow-up issue to #1622, the cluster controller should update Status.InfrastructureReady if the linked infrastructure reference Status.Ready changes.

/kind feature
/milestone v0.3.0
/priority important-longterm
@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 25, 2019
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Oct 25, 2019
@joonas
Copy link

joonas commented Dec 6, 2019

/assign @vincepri

@vincepri vincepri mentioned this issue Dec 6, 2019
Merged
@lubronzhan
Copy link
Contributor

lubronzhan commented Mar 22, 2021 •
edited
Loading

Hi @vincepri , should the controller also update the status.conditions.InfrastructureReady as well? I run into a strange situation when deleting a cluster. I have a finalizer that blocks deleting. And a controller should remove that finalizer if cluster is in Ready state, however I checked the cluster status, the cluster status is Infrastructure Ready: true, but inside status.conditions, InfrastructureReady is false, thus making the ready condition false. So the deletion was stuck.

  Conditions:
    Last Transition Time:     2021-03-18T11:32:49Z
    Reason:                   Deleting
    Severity:                 Info
    Status:                   False
    Type:                     Ready
    Last Transition Time:     2021-03-17T08:18:06Z
    Status:                   True
    Type:                     ControlPlaneReady
    Last Transition Time:     2021-03-18T11:32:49Z
    Reason:                   Deleting
    Severity:                 Info
    Status:                   False
    Type:                     InfrastructureReady
  Control Plane Initialized:  true
  Control Plane Ready:        true
  Infrastructure Ready:       true
  Observed Generation:        3
  Phase:                      Deleting
Events:                       <none>

In the underlying infra object, the readyness is also true

apiVersion: infrastructure.cluster.x-k8s.io/v1alpha3
kind: VSphereCluster
...
status:
  conditions:
  - lastTransitionTime: "2021-03-18T11:32:49Z"
    reason: Deleting
    severity: Info
    status: "False"
    type: Ready
  - lastTransitionTime: "2021-03-18T11:32:49Z"
    reason: Deleting
    severity: Info
    status: "False"
    type: CCMAvailable
  - lastTransitionTime: "2021-03-18T11:32:49Z"
    reason: Deleting
    severity: Info
    status: "False"
    type: CSIAvailable
  - lastTransitionTime: "2021-03-17T08:01:25Z"
    status: "True"
    type: LoadBalancerAvailable
  ready: true

K8S version: v1.20.4
IAAS: vSphere
CAPI version: 0.3.14

@vincepri
Copy link
Member Author

Hi @lubronzhan, we usually don't use closed issues. Could you please open a new one with the context above?

@lubronzhan
Copy link
Contributor

Yeah sure thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincepri vincepri

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

⚠️ Sync InfraCluster.Status.Ready to Cluster object vincepri/cluster-api
4 participants
@joonas @vincepri @lubronzhan @k8s-ci-robot