Skip to content

Add ClusterClass proposal API types #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabriziopandini opened this issue Jul 9, 2021 · 2 comments · Fixed by #4928
Closed

Add ClusterClass proposal API types #4908

fabriziopandini opened this issue Jul 9, 2021 · 2 comments · Fixed by #4928
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@fabriziopandini
Copy link
Member

Detailed Description

As an initial activity for the implementation of the ClusterClass proposal we should add/change API types ad defined in the proposal.

This change should also include web hook changes as defined by the document in the validation paragraph; This can be eventually a follow up PR if we want to parallelise work.

With this regard I suggest some small amendments to the proposal

ClusterClass

  • For object updates:
    • spec.worker.deployments[i].class field must be unique within a ClusterClass (added; it is already there for object create)

Cluster

  • For object creation:

    • spec.topology and spec.infrastructureRef cannot be simultaneously set (added; there is already a similar check for controlPlaneRef)

@srm09 @vincepri PTAL to the proposed amendments to the proposal

/kind feature

@fabriziopandini fabriziopandini added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 9, 2021
@fabriziopandini fabriziopandini added this to the v0.4 milestone Jul 9, 2021
@fabriziopandini
Copy link
Member Author

/assign

@srm09
Copy link
Contributor

srm09 commented Jul 13, 2021

Nice catch @fabriziopandini , missed these :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants