🐛 SetLogger should work with nil sinks

Signed-off-by: Vince Prignano <[email protected]>

Author: vincepri

pkg/log/deleg.go

@@ -188,6 +188,9 @@ func (l *delegatingLogSink) WithValues(tags ...interface{}) logr.LogSink {
 // provided, instead of the temporary initial one, if this method
 // has not been previously called.
 func (l *delegatingLogSink) Fulfill(actual logr.LogSink) {
+	if actual == nil {
+		actual = NullLogSink{}
+	}
 	if l.promise != nil {
 		l.promise.Fulfill(actual)
 	}

pkg/log/log_test.go

@@ -98,6 +98,13 @@ func (f *fakeLogger) Enabled(level int) bool { return true }
 var _ = Describe("logging", func() {
 
 	Describe("top-level logger", func() {
+		It("should be able to use logr.Discard", func() {
+			SetLogger(logr.Discard())
+			By("grabbing a sub-logger and logging")
+			l1 := Log.WithName("runtimeLog").WithValues("newtag", "newvalue2")
+			l1.Info("test")
+		})
+
 		It("hold newly created loggers until a logger is set", func() {
 			By("grabbing a new sub-logger and logging to it")
 			l1 := Log.WithName("runtimeLog").WithValues("newtag", "newvalue1")