Merge pull request #3037 from kubernetes-sigs/backport019-watch

k8s-ci-robot · web-flow · commit 3e6681045387 · 2024-12-02T16:51:00.000Z
🌱 add deprecated Watch() to certwatcher
diff --git a/pkg/certwatcher/certwatcher.go b/pkg/certwatcher/certwatcher.go
@@ -104,6 +104,13 @@ func (cw *CertWatcher) Start(ctx context.Context) error {
 	}
 }
 
+// Watch used to read events from the watcher's channel and reacts to changes,
+// it has currently no function and it's left here for backward compatibility until a future release.
+//
+// Deprecated: fsnotify has been removed and Start() is now polling instead.
+func (cw *CertWatcher) Watch() {
+}
+
 // updateCachedCertificate checks if the new certificate differs from the cache,
 // updates it and returns the result if it was updated or not
 func (cw *CertWatcher) updateCachedCertificate(cert *tls.Certificate, keyPEMBlock []byte) bool {

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,13 @@ func (cw *CertWatcher) Start(ctx context.Context) error {`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
	`107`	`+// Watch used to read events from the watcher's channel and reacts to changes,`
	`108`	`+// it has currently no function and it's left here for backward compatibility until a future release.`
	`109`	`+//`
	`110`	`+// Deprecated: fsnotify has been removed and Start() is now polling instead.`
	`111`	`+func (cw *CertWatcher) Watch() {`
	`112`	`+}`
	`113`	`+`
`107`	`114`	`// updateCachedCertificate checks if the new certificate differs from the cache,`
`108`	`115`	`// updates it and returns the result if it was updated or not`
`109`	`116`	`func (cw CertWatcher) updateCachedCertificate(cert tls.Certificate, keyPEMBlock []byte) bool {`