Skip to content

Commit 4195d2d

Browse files
authored
Merge pull request #1096 from vincepri/increase-verbosity
⚠️ Remove logs from internal controller
2 parents 79da425 + d10e451 commit 4195d2d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

pkg/internal/controller/controller.go

-6
Original file line numberDiff line numberDiff line change
@@ -239,9 +239,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
239239
// resource to be synced.
240240
if result, err := c.Do.Reconcile(ctx, req); err != nil {
241241
c.Queue.AddRateLimited(req)
242-
if log.V(3).Enabled() {
243-
log.Error(err, "Reconciler error")
244-
}
245242
ctrlmetrics.ReconcileErrors.WithLabelValues(c.Name).Inc()
246243
ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "error").Inc()
247244
return false
@@ -264,9 +261,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
264261
// get queued again until another change happens.
265262
c.Queue.Forget(obj)
266263

267-
// TODO(directxman12): What does 1 mean? Do we want level constants? Do we want levels at all?
268-
log.V(5).Info("Successfully Reconciled")
269-
270264
ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "success").Inc()
271265
// Return true, don't take a break
272266
return true

0 commit comments

Comments
 (0)