Merge pull request #1102 from vincepri/remove-deprecated-builder-funs

⚠️ Remove deprecated For/WithConfig from controller builder

Author: k8s-ci-robot

pkg/builder/controller.go

@@ -56,16 +56,6 @@ func ControllerManagedBy(m manager.Manager) *Builder {
 	return &Builder{mgr: m}
 }
 
-// ForType defines the type of Object being *reconciled*, and configures the ControllerManagedBy to respond to create / delete /
-// update events by *reconciling the object*.
-// This is the equivalent of calling
-// Watches(&source.Kind{Type: apiType}, &handler.EnqueueRequestForObject{})
-//
-// Deprecated: Use For
-func (blder *Builder) ForType(apiType runtime.Object) *Builder {
-	return blder.For(apiType)
-}
-
 // ForInput represents the information set by For method.
 type ForInput struct {
 	object     runtime.Object
@@ -125,14 +115,6 @@ func (blder *Builder) Watches(src source.Source, eventhandler handler.EventHandl
 	return blder
 }
 
-// WithConfig sets the Config to use for configuring clients.  Defaults to the in-cluster config or to ~/.kube/config.
-//
-// Deprecated: Use ControllerManagedBy(Manager) and this isn't needed.
-func (blder *Builder) WithConfig(config *rest.Config) *Builder {
-	blder.config = config
-	return blder
-}
-
 // WithEventFilter sets the event filters, to filter which create/update/delete/generic events eventually
 // trigger reconciliations.  For example, filtering on whether the resource version has changed.
 // Given predicate is added for all watched objects.