🐛 stop using hardcoded temp dir

Mengqi Yu · Mengqi Yu · commit 90c83df68bb7 · 2019-07-22T16:26:46.000-07:00
We now use https://golang.org/pkg/os/#TempDir to get the os specific temp dir. Otherwise, it won't work for Windows users.
diff --git a/pkg/webhook/server.go b/pkg/webhook/server.go
@@ -22,6 +22,7 @@ import (
 	"fmt"
 	"net"
 	"net/http"
+	"os"
 	"path"
 	"path/filepath"
 	"strconv"
@@ -85,7 +86,7 @@ func (s *Server) setDefaults() {
 	}
 
 	if len(s.CertDir) == 0 {
-		s.CertDir = path.Join("/tmp", "k8s-webhook-server", "serving-certs")
+		s.CertDir = path.Join(os.TempDir(), "k8s-webhook-server", "serving-certs")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ import (`
`22`	`22`	`"fmt"`
`23`	`23`	`"net"`
`24`	`24`	`"net/http"`
	`25`	`+ "os"`
`25`	`26`	`"path"`
`26`	`27`	`"path/filepath"`
`27`	`28`	`"strconv"`
`@@ -85,7 +86,7 @@ func (s *Server) setDefaults() {`
`85`	`86`	`}`
`86`	`87`
`87`	`88`	`if len(s.CertDir) == 0 {`
`88`		`- s.CertDir = path.Join("/tmp", "k8s-webhook-server", "serving-certs")`
	`89`	`+ s.CertDir = path.Join(os.TempDir(), "k8s-webhook-server", "serving-certs")`
`89`	`90`	`}`
`90`	`91`	`}`
`91`	`92`