Skip to content

Commit add0b64

Browse files
authored
Merge pull request #1016 from msiebuhr/fix-webhook-example
🐛 Fix webhook example
2 parents 4836ec2 + 5db0b9d commit add0b64

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

Diff for: pkg/webhook/example_test.go

+8-5
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ import (
2424
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
2525
)
2626

27-
var (
28-
mgr ctrl.Manager
29-
)
30-
3127
func Example() {
3228
// Build webhooks
3329
// These handlers could be also be implementations
@@ -48,6 +44,13 @@ func Example() {
4844
}),
4945
}
5046

47+
// Create a manager
48+
// Note: GetConfigOrDie will os.Exit(1) w/o any message if no kube-config can be found
49+
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{})
50+
if err != nil {
51+
panic(err)
52+
}
53+
5154
// Create a webhook server.
5255
hookServer := &Server{
5356
Port: 8443,
@@ -61,7 +64,7 @@ func Example() {
6164
hookServer.Register("/validating", validatingHook)
6265

6366
// Start the server by starting a previously-set-up manager
64-
err := mgr.Start(ctrl.SetupSignalHandler())
67+
err = mgr.Start(ctrl.SetupSignalHandler())
6568
if err != nil {
6669
// handle error
6770
panic(err)

0 commit comments

Comments
 (0)