Skip to content

Commit f15bad2

Browse files
committed
Rename to Object
Signed-off-by: ruromero <[email protected]>
1 parent 1d05f23 commit f15bad2

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

pkg/controller/controllerutil/controllerutil.go

+6-14
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,14 @@ func newAlreadyOwnedError(Object metav1.Object, Owner metav1.OwnerReference) *Al
5555
// reconciling the owner object on changes to controlled (with a Watch + EnqueueRequestForOwner).
5656
// Since only one OwnerReference can be a controller, it returns an error if
5757
// there is another OwnerReference with Controller flag set.
58-
func SetControllerReference(owner, controlled metav1.Object, scheme *runtime.Scheme) error {
58+
func SetControllerReference(owner, controlled Object, scheme *runtime.Scheme) error {
5959
// Validate the owner.
60-
ro, ok := owner.(runtime.Object)
61-
if !ok {
62-
return fmt.Errorf("%T is not a runtime.Object, cannot call SetControllerReference", owner)
63-
}
6460
if err := validateOwner(owner, controlled); err != nil {
6561
return err
6662
}
6763

6864
// Create a new controller ref.
69-
gvk, err := apiutil.GVKForObject(ro, scheme)
65+
gvk, err := apiutil.GVKForObject(controlled, scheme)
7066
if err != nil {
7167
return err
7268
}
@@ -92,18 +88,14 @@ func SetControllerReference(owner, controlled metav1.Object, scheme *runtime.Sch
9288
// SetOwnerReference is a helper method to make sure the given object contains an object reference to the object provided.
9389
// This allows you to declare that owner has a dependency on the object without specifying it as a controller.
9490
// If a reference to the same object already exists, it'll be overwritten with the newly provided version.
95-
func SetOwnerReference(owner, object metav1.Object, scheme *runtime.Scheme) error {
91+
func SetOwnerReference(owner, object Object, scheme *runtime.Scheme) error {
9692
// Validate the owner.
97-
ro, ok := owner.(runtime.Object)
98-
if !ok {
99-
return fmt.Errorf("%T is not a runtime.Object, cannot call SetOwnerReference", owner)
100-
}
10193
if err := validateOwner(owner, object); err != nil {
10294
return err
10395
}
10496

10597
// Create a new owner ref.
106-
gvk, err := apiutil.GVKForObject(ro, scheme)
98+
gvk, err := apiutil.GVKForObject(object, scheme)
10799
if err != nil {
108100
return err
109101
}
@@ -281,9 +273,9 @@ func RemoveFinalizerWithError(o runtime.Object, finalizer string) error {
281273
return nil
282274
}
283275

284-
// KubernetesObject allows functions to work indistinctly with any resource that
276+
// Object allows functions to work indistinctly with any resource that
285277
// implements both Object interfaces.
286-
type KubernetesObject interface {
278+
type Object interface {
287279
metav1.Object
288280
runtime.Object
289281
}

0 commit comments

Comments
 (0)