Skip to content

Commit d9cb41e

Browse files
authored
Merge pull request #495 from matthchr/feature/cabundle
🐛 Remove unneeded caBundle: Cg== value
2 parents 9d7db16 + ea00a02 commit d9cb41e

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

pkg/crd/markers/zz_generated.markerhelp.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/webhook/parser.go

-4
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,6 @@ func (c Config) clientConfig() admissionregv1.WebhookClientConfig {
244244
Namespace: "system",
245245
Path: &path,
246246
},
247-
// OpenAPI marks the field as required before 1.13 because of a bug that got fixed in
248-
// https://github.com/kubernetes/api/commit/e7d9121e9ffd63cea0288b36a82bcc87b073bd1b
249-
// Put "\n" as an placeholder as a workaround til 1.13+ is almost everywhere.
250-
CABundle: []byte("\n"),
251247
}
252248
}
253249

pkg/webhook/testdata/manifests.v1beta1.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ webhooks:
1010
- v1
1111
- v1beta1
1212
clientConfig:
13-
caBundle: Cg==
1413
service:
1514
name: webhook-service
1615
namespace: system
@@ -38,7 +37,6 @@ metadata:
3837
name: validating-webhook-configuration
3938
webhooks:
4039
- clientConfig:
41-
caBundle: Cg==
4240
service:
4341
name: webhook-service
4442
namespace: system

pkg/webhook/testdata/manifests.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ webhooks:
1010
- v1
1111
- v1beta1
1212
clientConfig:
13-
caBundle: Cg==
1413
service:
1514
name: webhook-service
1615
namespace: system
@@ -41,7 +40,6 @@ webhooks:
4140
- v1
4241
- v1beta1
4342
clientConfig:
44-
caBundle: Cg==
4543
service:
4644
name: webhook-service
4745
namespace: system

0 commit comments

Comments
 (0)