Skip to content

Role ordering is not stable #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgustie opened this issue Jul 11, 2019 · 3 comments · Fixed by #253
Closed

Role ordering is not stable #251

jgustie opened this issue Jul 11, 2019 · 3 comments · Fixed by #253
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jgustie
Copy link

jgustie commented Jul 11, 2019

Using 0.2.0-beta.3 the RBAC generator is modifying files on every pass. I think this is due to the #235 changes: the ultimate ordering of the policy rules slice is now determined by a map iteration.

I'm still transitioning from Java to Go, but I think the fix is to aggregate the rules keys into another slice, sort the ruleKey slice and iterate over that when building the list of policy rules.

@DirectXMan12
Copy link
Contributor

they should be being sorted @haiyanmeng FYI

@DirectXMan12
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 11, 2019
@haiyanmeng
Copy link
Contributor

/assign @haiyanmeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants