Upgrade golangci-lint.

Fix additional linter issues.

Signed-off-by: Michael Montgomery <[email protected]>

Author: naemono

Makefile

@@ -7,7 +7,7 @@ GOPATH:=$(shell go env GOPATH)
 
 VERSION?=latest
 
-GOLANGCI_VERSION:=1.55.2
+GOLANGCI_VERSION:=1.63.4
 
 .PHONY: all
 all: build-test-adapter

pkg/apiserver/installer/apiserver_test.go

@@ -300,7 +300,7 @@ func TestCustomMetricsAPI(t *testing.T) {
 	for k, v := range cases {
 		response, err := executeRequest(t, k, v, server, &client)
 		if err != nil {
-			t.Errorf(err.Error())
+			t.Errorf("%s", err.Error())
 			continue
 		}
 		if v.ExpectedCount > 0 {
@@ -342,7 +342,7 @@ func TestExternalMetricsAPI(t *testing.T) {
 	for k, v := range cases {
 		response, err := executeRequest(t, k, v, server, &client)
 		if err != nil {
-			t.Errorf(err.Error())
+			t.Errorf("%s", err.Error())
 			continue
 		}
 		if v.ExpectedCount > 0 {

test-adapter/main.go

@@ -75,7 +75,7 @@ func main() {
 		klog.Fatalf("unable to register metrics: %v", err)
 	}
 
-	klog.Infof(cmd.Message)
+	klog.Infof("%s", cmd.Message)
 	// Set up POST endpoint for writing fake metric values
 	restful.DefaultContainer.Add(webService)
 	go func() {