Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable handling of node NotReady #4991

Closed
jbalonso opened this issue Jan 5, 2025 · 2 comments · Fixed by #5045
Closed

Configurable handling of node NotReady #4991

jbalonso opened this issue Jan 5, 2025 · 2 comments · Fixed by #5045
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jbalonso
Copy link

jbalonso commented Jan 5, 2025

What would you like to be added:

I would like the behavior requested in #1112 and implemented in #4761 to be made configurable. I have no opinion on default behavior.

Why is this needed:

I have node management automation (including node upgrade automation) that would preferably rely on DNS (as managed by external-dns) to access nodes in the performance of maintenance. My automation tools run outside of the cluster. This tooling broke when #4761 was released.

In a cluster where services are not exposed via node IPs (let alone node hostnames), the intent behind #4761 does not apply.
@jbalonso jbalonso added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2025
@Hayajiro Hayajiro mentioned this issue Jan 29, 2025
Merged
2 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2025
@jbalonso
Copy link
Author

jbalonso commented Apr 5, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(source): optional exclusion of unschedulable nodes Hayajiro/external-dns
3 participants
@jbalonso @k8s-ci-robot @k8s-triage-robot