Addressed more comments

Author: ahg-g

pkg/ext-proc/backend/datastore.go

@@ -31,7 +31,7 @@ type Datastore interface {
 
 	// PodMetrics operations
 	PodUpdateOrAddIfNotExist(pod *corev1.Pod) bool
-	PodUpdateMetricsIfExist(pm *PodMetrics) bool
+	PodUpdateMetricsIfExist(namespacedName types.NamespacedName, m *Metrics) bool
 	PodGet(namespacedName types.NamespacedName) (*PodMetrics, bool)
 	PodDelete(namespacedName types.NamespacedName)
 	PodResyncAll(ctx context.Context, ctrlClient client.Client)
@@ -115,10 +115,10 @@ func (ds *datastore) ModelDelete(modelName string) {
 }
 
 // /// Pods/endpoints APIs ///
-func (ds *datastore) PodUpdateMetricsIfExist(pm *PodMetrics) bool {
-	if val, ok := ds.pods.Load(pm.NamespacedName); ok {
+func (ds *datastore) PodUpdateMetricsIfExist(namespacedName types.NamespacedName, m *Metrics) bool {
+	if val, ok := ds.pods.Load(namespacedName); ok {
 		existing := val.(*PodMetrics)
-		existing.Metrics = pm.Metrics
+		existing.Metrics = *m
 		return true
 	}
 	return false

pkg/ext-proc/backend/inferencepool_reconciler.go

@@ -8,7 +8,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/tools/record"
-	klog "k8s.io/klog/v2"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/log"
@@ -59,10 +58,10 @@ func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 
 func (c *InferencePoolReconciler) updateDatastore(ctx context.Context, newPool *v1alpha1.InferencePool) {
 	logger := log.FromContext(ctx)
-	oldPool, _ := c.Datastore.PoolGet()
+	oldPool, err := c.Datastore.PoolGet()
 	c.Datastore.PoolSet(newPool)
-	if oldPool == nil || !reflect.DeepEqual(newPool.Spec.Selector, oldPool.Spec.Selector) {
-		logger.V(logutil.DEFAULT).Info("Updating inference pool endpoints", "target", klog.KMetadata(&newPool.ObjectMeta))
+	if err != nil || !reflect.DeepEqual(newPool.Spec.Selector, oldPool.Spec.Selector) {
+		logger.V(logutil.DEFAULT).Info("Updating inference pool endpoints", "selector", newPool.Spec.Selector)
 		c.Datastore.PodResyncAll(ctx, c.Client)
 	}
 }

pkg/ext-proc/backend/provider.go

@@ -109,7 +109,7 @@ func (p *Provider) refreshMetricsOnce(logger logr.Logger) error {
 				errCh <- fmt.Errorf("failed to parse metrics from %s: %v", existing.NamespacedName, err)
 				return
 			}
-			p.datastore.PodUpdateMetricsIfExist(updated)
+			p.datastore.PodUpdateMetricsIfExist(updated.NamespacedName, &updated.Metrics)
 			loggerTrace.Info("Updated metrics for pod", "pod", updated.NamespacedName, "metrics", updated.Metrics)
 		}()
 		return true

pkg/ext-proc/test/utils.go

@@ -44,7 +44,7 @@ func StartExtProc(
 			IP(pm.Address).
 			Obj()
 		datastore.PodUpdateOrAddIfNotExist(&pod)
-		datastore.PodUpdateMetricsIfExist(pm)
+		datastore.PodUpdateMetricsIfExist(pm.NamespacedName, &pm.Metrics)
 	}
 	pp := backend.NewProvider(pmc, datastore)
 	if err := pp.Init(ctx, refreshMetricsInterval, refreshPrometheusMetricsInterval); err != nil {