Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 39fdf33

Browse files
Adarsh AgrawalAdarsh Agrawal
Adarsh Agrawal
authored and
Adarsh Agrawal
committedFeb 3, 2025·
Using constants for the repeated values
1 parent 7639e6f commit 39fdf33

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed
 

‎pkg/ext-proc/test/benchmark/benchmark.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@ import (
1414
"inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/backend"
1515
"inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/test"
1616
klog "k8s.io/klog/v2"
17+
18+
runserver "inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/server"
1719
)
1820

1921
var (
20-
svrAddr = flag.String("server_address", "localhost:9002", "Address of the ext proc server")
22+
svrAddr = flag.String("server_address", fmt.Sprintf("localhost:%d", runserver.DefaultGrpcPort), "Address of the ext proc server")
2123
totalRequests = flag.Int("total_requests", 100000, "number of requests to be sent for load test")
2224
// Flags when running a local ext proc server.
2325
numFakePods = flag.Int("num_fake_pods", 200, "number of fake pods when running a local ext proc server")
@@ -28,7 +30,7 @@ var (
2830
)
2931

3032
const (
31-
port = 9002
33+
port = runserver.DefaultGrpcPort
3234
)
3335

3436
func main() {

‎test/integration/hermetic_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ func SKIPTestHandleRequestBody(t *testing.T) {
111111
wantHeaders: []*configPb.HeaderValueOption{
112112
{
113113
Header: &configPb.HeaderValue{
114-
Key: "target-pod",
114+
Key: runserver.DefaultTargetPodHeader,
115115
RawValue: []byte("address-1"),
116116
},
117117
},
@@ -176,7 +176,7 @@ func TestKubeInferenceModelRequest(t *testing.T) {
176176
wantHeaders: []*configPb.HeaderValueOption{
177177
{
178178
Header: &configPb.HeaderValue{
179-
Key: "target-pod",
179+
Key: runserver.DefaultTargetPodHeader,
180180
RawValue: []byte("address-1"),
181181
},
182182
},

0 commit comments

Comments
 (0)
Please sign in to comment.