Lint fixes/updating .golangci to not use deprecated linter (#125)

* Lint fixes updating .golangci to not use deprecated linter

* running make manifests and adding it generate command

* spacing fix

Author: kfswain

.golangci.yml

@@ -21,7 +21,7 @@ linters:
   enable:
     - dupl
     - errcheck
-    - exportloopref
+    - copyloopvar
     - ginkgolinter
     - goconst
     - gocyclo

Makefile

@@ -48,7 +48,7 @@ manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and Cust
 	$(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
 
 .PHONY: generate
-generate: controller-gen code-generator ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
+generate: controller-gen code-generator manifests ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
 	$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."
 	./hack/update-codegen.sh
 

api/v1alpha1/inferencepool_types.go

@@ -36,7 +36,7 @@ type InferencePoolSpec struct {
 	Selector map[LabelKey]LabelValue `json:"selector,omitempty"`
 
 	// TargetPortNumber is the port number that the model servers within the pool expect
-	// to recieve traffic from.
+	// to receive traffic from.
 	// This maps to the TargetPort in: https://pkg.go.dev/k8s.io/api/core/v1#ServicePort
 	//
 	// +kubebuilder:validation:Minimum=0

config/crd/bases/inference.networking.x-k8s.io_inferencepools.yaml

@@ -68,7 +68,7 @@ spec:
               targetPortNumber:
                 description: |-
                   TargetPortNumber is the port number that the model servers within the pool expect
-                  to recieve traffic from.
+                  to receive traffic from.
                   This maps to the TargetPort in: https://pkg.go.dev/k8s.io/api/core/v1#ServicePort
                 format: int32
                 maximum: 65535

pkg/ext-proc/main.go

@@ -29,20 +29,48 @@ import (
 )
 
 var (
-	port                   = flag.Int("port", 9002, "gRPC port")
-	targetPodHeader        = flag.String("targetPodHeader", "target-pod", "the header key for the target pod address to instruct Envoy to send the request to. This must match Envoy configuration.")
-	serverPoolName         = flag.String("serverPoolName", "", "Name of the serverPool this Endpoint Picker is associated with.")
-	serviceName            = flag.String("serviceName", "", "Name of the service that will be used to read the endpointslices from")
-	namespace              = flag.String("namespace", "default", "The Namespace that the server pool should exist in.")
-	zone                   = flag.String("zone", "", "The zone that this instance is created in. Will be passed to the corresponding endpointSlice. ")
-	refreshPodsInterval    = flag.Duration("refreshPodsInterval", 10*time.Second, "interval to refresh pods")
-	refreshMetricsInterval = flag.Duration("refreshMetricsInterval", 50*time.Millisecond, "interval to refresh metrics")
-	scheme                 = runtime.NewScheme()
+	port = flag.Int(
+		"port",
+		9002,
+		"gRPC port")
+	targetPodHeader = flag.String(
+		"targetPodHeader",
+		"target-pod",
+		"Header key used by Envoy to route to the appropriate pod. This must match Envoy configuration.")
+	serverPoolName = flag.String(
+		"serverPoolName",
+		"",
+		"Name of the serverPool this Endpoint Picker is associated with.")
+	serviceName = flag.String(
+		"serviceName",
+		"",
+		"Name of the service that will be used to read the endpointslices from")
+	namespace = flag.String(
+		"namespace",
+		"default",
+		"The Namespace that the server pool should exist in.")
+	zone = flag.String(
+		"zone",
+		"",
+		"The zone that this instance is created in. Will be passed to the corresponding endpointSlice. ")
+	refreshPodsInterval = flag.Duration(
+		"refreshPodsInterval",
+		10*time.Second,
+		"interval to refresh pods")
+	refreshMetricsInterval = flag.Duration(
+		"refreshMetricsInterval",
+		50*time.Millisecond,
+		"interval to refresh metrics")
+
+	scheme = runtime.NewScheme()
 )
 
 type healthServer struct{}
 
-func (s *healthServer) Check(ctx context.Context, in *healthPb.HealthCheckRequest) (*healthPb.HealthCheckResponse, error) {
+func (s *healthServer) Check(
+	ctx context.Context,
+	in *healthPb.HealthCheckRequest,
+) (*healthPb.HealthCheckResponse, error) {
 	klog.Infof("Handling grpc Check request + %s", in.String())
 	return &healthPb.HealthCheckResponse{Status: healthPb.HealthCheckResponse_SERVING}, nil
 }
@@ -134,7 +162,13 @@ func main() {
 	if err := pp.Init(*refreshPodsInterval, *refreshMetricsInterval); err != nil {
 		klog.Fatalf("failed to initialize: %v", err)
 	}
-	extProcPb.RegisterExternalProcessorServer(s, handlers.NewServer(pp, scheduling.NewScheduler(pp), *targetPodHeader, datastore))
+	extProcPb.RegisterExternalProcessorServer(
+		s,
+		handlers.NewServer(
+			pp,
+			scheduling.NewScheduler(pp),
+			*targetPodHeader,
+			datastore))
 	healthPb.RegisterHealthServer(s, &healthServer{})
 
 	klog.Infof("Starting gRPC server on port :%v", *port)
@@ -155,6 +189,9 @@ func main() {
 
 	}()
 
-	s.Serve(lis)
+	err = s.Serve(lis)
+	if err != nil {
+		klog.Fatalf("Ext-proc failed with the err: %v", err)
+	}
 
 }

pkg/ext-proc/test/hermetic_test.go

@@ -38,7 +38,7 @@ func TestHandleRequestBody(t *testing.T) {
 			name: "success",
 			req:  GenerateRequest("my-model"),
 			models: map[string]*v1alpha1.InferenceModel{
-				"my-model": &v1alpha1.InferenceModel{
+				"my-model": {
 					Spec: v1alpha1.InferenceModelSpec{
 						ModelName: "my-model",
 						TargetModels: []v1alpha1.TargetModel{