Add build targets for lora syncer

Signed-off-by: Kunjan <[email protected]>

Author: coolkp

Makefile

@@ -26,6 +26,7 @@ PLATFORMS ?= linux/amd64
 DOCKER_BUILDX_CMD ?= docker buildx
 IMAGE_BUILD_CMD ?= $(DOCKER_BUILDX_CMD) build
 IMAGE_BUILD_EXTRA_OPTS ?=
+SYNCER_IMAGE_BUILD_EXTRA_OPTS ?=
 IMAGE_REGISTRY ?= us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension
 IMAGE_NAME := epp
 IMAGE_REPO ?= $(IMAGE_REGISTRY)/$(IMAGE_NAME)
@@ -43,9 +44,11 @@ endif
 
 ifdef EXTRA_TAG
 IMAGE_EXTRA_TAG ?= $(IMAGE_REPO):$(EXTRA_TAG)
+SYNCER_IMAGE_EXTRA_TAG ?= $(SYNCER_IMAGE_REPO):$(EXTRA_TAG)
 endif
 ifdef IMAGE_EXTRA_TAG
 IMAGE_BUILD_EXTRA_OPTS += -t $(IMAGE_EXTRA_TAG)
+SYNCER_IMAGE_BUILD_EXTRA_OPTS += -t $(SYNCER_IMAGE_EXTRA_TAG)
 endif
 
 # The name of the kind cluster to use for the "kind-load" target.
@@ -167,31 +170,6 @@ image-build: ## Build the EPP image using Docker Buildx.
 image-push: PUSH=--push ## Build the EPP image and push it to $IMAGE_REPO.
 image-push: image-build
 
-##@ Lora Syncer
-
-.PHONY: syncer-image-local-build
-syncer-image-local-build:
-	BUILDER=$(shell $(DOCKER_BUILDX_CMD) create --use)
-	$(MAKE) image-build PUSH=$(PUSH)
-	$(DOCKER_BUILDX_CMD) rm $$BUILDER
-
-.PHONY: syncer-image-local-push
-syncer-image-local-push: PUSH=--push
-syncer-image-local-push: syncer-image-local-build
-
-.PHONY: syncer-image-build
-syncer-image-build:
-	$ cd $(CURDIR)/tools/dynamic-lora-sidecar && $(IMAGE_BUILD_CMD) -t $(SYNCER_IMAGE_TAG) \
-		--platform=$(PLATFORMS) \
-		--build-arg BASE_IMAGE=$(BASE_IMAGE) \
-		--build-arg BUILDER_IMAGE=$(BUILDER_IMAGE) \
-		$(PUSH) \
-		$(IMAGE_BUILD_EXTRA_OPTS) ./
-
-.PHONY: syncer-image-push
-syncer-image-push: PUSH=--push
-syncer-image-push: syncer-image-build
-
 .PHONY: image-load
 image-load: LOAD=--load ## Build the EPP image and load it in the local Docker registry.
 image-load: image-build
@@ -219,20 +197,12 @@ syncer-image-build:
 		--build-arg BASE_IMAGE=$(BASE_IMAGE) \
 		--build-arg BUILDER_IMAGE=$(BUILDER_IMAGE) \
 		$(PUSH) \
-		$(IMAGE_BUILD_EXTRA_OPTS) ./
+		$(SYNCER_IMAGE_BUILD_EXTRA_OPTS) ./
 
 .PHONY: syncer-image-push
 syncer-image-push: PUSH=--push
 syncer-image-push: syncer-image-build
 
-.PHONY: image-load
-image-load: LOAD=--load ## Build the EPP image and load it in the local Docker registry.
-image-load: image-build
-
-.PHONY: image-kind
-image-kind: image-build ## Build the EPP image and load it to kind cluster $KIND_CLUSTER ("kind" by default).
-	kind load docker-image $(IMAGE_TAG) --name $(KIND_CLUSTER)
-
 ##@ Docs
 
 .PHONY: build-docs

site-src/guides/dynamic-lora.md

@@ -40,6 +40,9 @@ Rest of the steps are same as [general setup](https://github.com/kubernetes-sigs
                     - base-model: meta-llama/Llama-2-7b-hf
                       id: tweet-summary-1
                       source: vineetsharma/qlora-adapter-Llama-2-7b-hf-TweetSumm
+                    - base-model: meta-llama/Llama-2-7b-hf
+                      id: tweet-summary-2
+                      source: vineetsharma/qlora-adapter-Llama-2-7b-hf-TweetSumm
     ```
 
 2. Configure a canary rollout with traffic split using LLMService. In this example, 40% of traffic for tweet-summary model will be sent to the ***tweet-summary-2*** adapter .
@@ -49,7 +52,7 @@ model:
     name: tweet-summary
     targetModels:
     targetModelName: tweet-summary-0
-            weight: 10
+            weight: 20
     targetModelName: tweet-summary-1
             weight: 40
     targetModelName: tweet-summary-2