Skip to content

Commit 5d32bf3

Browse files
Using constants for the repeated values (#273)
1 parent a0fe167 commit 5d32bf3

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

pkg/ext-proc/test/benchmark/benchmark.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,13 @@ import (
1212
"google.golang.org/protobuf/proto"
1313
"inference.networking.x-k8s.io/gateway-api-inference-extension/api/v1alpha1"
1414
"inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/backend"
15+
runserver "inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/server"
1516
"inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/test"
1617
klog "k8s.io/klog/v2"
1718
)
1819

1920
var (
20-
svrAddr = flag.String("server_address", "localhost:9002", "Address of the ext proc server")
21+
svrAddr = flag.String("server_address", fmt.Sprintf("localhost:%d", runserver.DefaultGrpcPort), "Address of the ext proc server")
2122
totalRequests = flag.Int("total_requests", 100000, "number of requests to be sent for load test")
2223
// Flags when running a local ext proc server.
2324
numFakePods = flag.Int("num_fake_pods", 200, "number of fake pods when running a local ext proc server")
@@ -28,7 +29,7 @@ var (
2829
)
2930

3031
const (
31-
port = 9002
32+
port = runserver.DefaultGrpcPort
3233
)
3334

3435
func main() {

test/integration/hermetic_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ func SKIPTestHandleRequestBody(t *testing.T) {
111111
wantHeaders: []*configPb.HeaderValueOption{
112112
{
113113
Header: &configPb.HeaderValue{
114-
Key: "target-pod",
114+
Key: runserver.DefaultTargetPodHeader,
115115
RawValue: []byte("address-1"),
116116
},
117117
},
@@ -176,7 +176,7 @@ func TestKubeInferenceModelRequest(t *testing.T) {
176176
wantHeaders: []*configPb.HeaderValueOption{
177177
{
178178
Header: &configPb.HeaderValue{
179-
Key: "target-pod",
179+
Key: runserver.DefaultTargetPodHeader,
180180
RawValue: []byte("address-1"),
181181
},
182182
},

0 commit comments

Comments
 (0)