Skip to content

Commit d7a9dfa

Browse files
kfswainahg-g
andauthored
cleanup logging (#514)
* cleanup logging * Update cmd/epp/health.go Co-authored-by: Abdullah Gharaibeh <[email protected]> --------- Co-authored-by: Abdullah Gharaibeh <[email protected]>
1 parent ba867c5 commit d7a9dfa

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

cmd/epp/health.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ type healthServer struct {
3434

3535
func (s *healthServer) Check(ctx context.Context, in *healthPb.HealthCheckRequest) (*healthPb.HealthCheckResponse, error) {
3636
if !s.datastore.PoolHasSynced() {
37-
s.logger.V(logutil.VERBOSE).Info("gRPC health check not serving", "service", in.Service)
37+
s.logger.V(logutil.DEFAULT).Info("gRPC health check not serving", "service", in.Service)
3838
return &healthPb.HealthCheckResponse{Status: healthPb.HealthCheckResponse_NOT_SERVING}, nil
3939
}
40-
s.logger.V(logutil.VERBOSE).Info("gRPC health check serving", "service", in.Service)
40+
s.logger.V(logutil.TRACE).Info("gRPC health check serving", "service", in.Service)
4141
return &healthPb.HealthCheckResponse{Status: healthPb.HealthCheckResponse_SERVING}, nil
4242
}
4343

pkg/epp/handlers/streamingserver.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
133133
loggerVerbose.Info("got response headers", "headers", v.ResponseHeaders.Headers.GetHeaders())
134134
for _, header := range v.ResponseHeaders.Headers.GetHeaders() {
135135
value := string(header.RawValue)
136-
logger.Error(nil, "header", "key", header.Key, "value", value)
136+
137+
logger.V(logutil.TRACE).Info("header", "key", header.Key, "value", value)
137138
if header.Key == "status" && value != "200" {
138139
reqCtx.ResponseStatusCode = errutil.ModelServerError
139140
} else if header.Key == "content-type" && strings.Contains(value, "text/event-stream") {

0 commit comments

Comments
 (0)