Skip to content

Commit db43b27

Browse files
rramkumar1robscott
andcommitted
Update pkg/body-based-routing/README.md
Co-authored-by: Rob Scott <[email protected]>
1 parent 800b1d4 commit db43b27

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Diff for: pkg/body-based-routing/handlers/request.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,28 @@ limitations under the License.
1717
package handlers
1818

1919
import (
20+
"context"
2021
"fmt"
2122
"encoding/json"
2223

24+
"sigs.k8s.io/controller-runtime/pkg/log"
25+
logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
2326
basepb "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"
2427
eppb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
2528
)
2629

2730
// HandleRequestBody handles request bodies.
28-
func (s *Server) HandleRequestBody(body *eppb.HttpBody) (*eppb.ProcessingResponse, error) {
31+
func (s *Server) HandleRequestBody(ctx context.Context, body *eppb.HttpBody) (*eppb.ProcessingResponse, error) {
32+
logger := log.FromContext(ctx)
33+
2934
var data map[string]any
3035
if err := json.Unmarshal(body.GetBody(), &data); err != nil {
3136
return nil, err
3237
}
3338

3439
modelVal, ok := data["model"]
3540
if !ok {
41+
logger.V(logutil.DEFAULT).Info("Request body does not contain model parameter")
3642
return &eppb.ProcessingResponse{
3743
Response: &eppb.ProcessingResponse_RequestBody{
3844
RequestBody: &eppb.BodyResponse{},
@@ -42,6 +48,7 @@ func (s *Server) HandleRequestBody(body *eppb.HttpBody) (*eppb.ProcessingRespons
4248

4349
modelStr, ok := modelVal.(string)
4450
if !ok {
51+
logger.V(logutil.DEFAULT).Error("Model parameter value is not a string")
4552
return &eppb.ProcessingResponse{
4653
Response: &eppb.ProcessingResponse_RequestBody{
4754
RequestBody: &eppb.BodyResponse{},

Diff for: pkg/body-based-routing/server/runserver.go

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ func (r *ExtProcServerRunner) AsRunnable(logger logr.Logger) manager.Runnable {
7474
}))
7575
}
7676

77-
// TODO(rramkumar1): This function is also implemented on the EPP side. We should share code.
7877
func createSelfSignedTLSCertificate(logger logr.Logger) (tls.Certificate, error) {
7978
serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128)
8079
serialNumber, err := rand.Int(rand.Reader, serialNumberLimit)

0 commit comments

Comments
 (0)