fix endpointslice_reconciler (#147)

MaYuan-02 · web-flow · commit f6d3e532596f · 2025-01-04T01:20:14.000+01:00
diff --git a/pkg/ext-proc/backend/endpointslice_reconciler.go b/pkg/ext-proc/backend/endpointslice_reconciler.go
@@ -47,6 +47,7 @@ func (c *EndpointSliceReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	return ctrl.Result{}, nil
 }
 
+// TODO: Support multiple endpointslices for a single service
 func (c *EndpointSliceReconciler) updateDatastore(
 	slice *discoveryv1.EndpointSlice,
 	inferencePool *v1alpha1.InferencePool) {
diff --git a/pkg/ext-proc/backend/inferencepool_reconciler.go b/pkg/ext-proc/backend/inferencepool_reconciler.go
@@ -25,7 +25,7 @@ type InferencePoolReconciler struct {
 }
 
 func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	if req.NamespacedName.Name != c.ServerPoolName && req.NamespacedName.Namespace != c.Namespace {
+	if req.NamespacedName.Name != c.ServerPoolName || req.NamespacedName.Namespace != c.Namespace {
 		return ctrl.Result{}, nil
 	}
 	klog.V(1).Info("reconciling InferencePool", req.NamespacedName)

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ func (c *EndpointSliceReconciler) Reconcile(ctx context.Context, req ctrl.Reques`
`47`	`47`	`return ctrl.Result{}, nil`
`48`	`48`	`}`
`49`	`49`
	`50`	`+// TODO: Support multiple endpointslices for a single service`
`50`	`51`	`func (c *EndpointSliceReconciler) updateDatastore(`
`51`	`52`	`slice *discoveryv1.EndpointSlice,`
`52`	`53`	`inferencePool *v1alpha1.InferencePool) {`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ type InferencePoolReconciler struct {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {`
`28`		`- if req.NamespacedName.Name != c.ServerPoolName && req.NamespacedName.Namespace != c.Namespace {`
	`28`	`+ if req.NamespacedName.Name != c.ServerPoolName \|\| req.NamespacedName.Namespace != c.Namespace {`
`29`	`29`	`return ctrl.Result{}, nil`
`30`	`30`	`}`
`31`	`31`	`klog.V(1).Info("reconciling InferencePool", req.NamespacedName)`