Skip to content

Commit fca9d2a

Browse files
authored
Tag the main version of the helm chart with v0 (i.e., latest dev version) (#547)
1 parent 4aa1019 commit fca9d2a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: cloudbuild.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ steps:
2525
args:
2626
- inferencepool-helm-chart-push
2727
env:
28-
- GIT_TAG=$_GIT_TAG
2928
- EXTRA_TAG=$_PULL_BASE_REF
3029
- GOTOOLCHAIN=auto
3130
- name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36

Diff for: hack/push-chart.sh

+3-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ set -o pipefail
2121
DEST_CHART_DIR=${DEST_CHART_DIR:-bin/}
2222

2323
EXTRA_TAG=${EXTRA_TAG:-$(git branch --show-current)}
24-
GIT_TAG=${GIT_TAG:-$(git tag | sort | grep -v rc | tail -n1)-$(git describe --tags --dirty --always)}
24+
CHART_VERSION=${CHART_VERSION:-"v0"}
2525

2626
STAGING_IMAGE_REGISTRY=${STAGING_IMAGE_REGISTRY:-us-central1-docker.pkg.dev/k8s-staging-images}
2727
IMAGE_REGISTRY=${IMAGE_REGISTRY:-${STAGING_IMAGE_REGISTRY}/gateway-api-inference-extension}
@@ -32,9 +32,10 @@ HELM=${HELM:-./bin/helm}
3232

3333
readonly semver_regex='^v([0-9]+)(\.[0-9]+){1,2}$'
3434

35-
chart_version=${GIT_TAG}
35+
chart_version=${CHART_VERSION}
3636
if [[ ${EXTRA_TAG} =~ ${semver_regex} ]]
3737
then
38+
# This is a release branch, use the release version
3839
${YQ} -i '.inferenceExtension.image.tag=strenv(EXTRA_TAG)' config/charts/inferencepool/values.yaml
3940
chart_version=${EXTRA_TAG}
4041
fi

0 commit comments

Comments
 (0)