Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InferenceModel Reconciler Log Message #187

Closed
danehans opened this issue Jan 10, 2025 · 1 comment · Fixed by #261
Closed

Fix InferenceModel Reconciler Log Message #187

danehans opened this issue Jan 10, 2025 · 1 comment · Fixed by #261
Assignees
@tchap
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@danehans
Copy link
Contributor

The following log line should have a space between the InferenceMode kind and the namespace/name:

Current:

inferencemodel_reconciler.go:27] reconciling InferenceModeldefault/inferencemodel-sample

Should be:

inferencemodel_reconciler.go:27] reconciling InferenceModel default/inferencemodel-sample
@danehans danehans added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 29, 2025
@tchap
Copy link
Contributor

tchap commented Jan 30, 2025

/assign

@tchap tchap mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tchap tchap

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

inferencemodel_reconciler: Fix a log message tchap/gateway-api-inference-extension
2 participants
@tchap @danehans