Skip to content

Clean up any more V(numeric) for log levels #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #362
kfswain opened this issue Feb 10, 2025 · 4 comments
Closed
Tracked by #362

Clean up any more V(numeric) for log levels #307

kfswain opened this issue Feb 10, 2025 · 4 comments

Comments

@kfswain
Copy link
Collaborator

kfswain commented Feb 10, 2025

We created: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/pkg/ext-proc/util/logging/logging_const.go

To more easily standardize our log levels. We should remove any more V(int), and either use an existing level, or define a new one with reasonable justification.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 10, 2025

duplicate #251 ?

@tchap
Copy link
Contributor

tchap commented Feb 13, 2025

This is actually handled as a side effect in #330

@tchap
Copy link
Contributor

tchap commented Feb 13, 2025

This can be now closed as #330 is merged.

@kfswain
Copy link
Collaborator Author

kfswain commented Feb 19, 2025

@tchap thank you very much!!

@kfswain kfswain closed this as completed Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants