Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle delete events in reconcilers #310

Closed
kfswain opened this issue Feb 10, 2025 · 2 comments
Closed

Properly handle delete events in reconcilers #310

kfswain opened this issue Feb 10, 2025 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kfswain
Copy link
Collaborator

kfswain commented Feb 10, 2025

This cropped up in: #286 (comment)

That comment thread also contains the context in how to adequately resolve delete events with controller-runtime. We should have proper delete handling for our inferenceModel reconciliation (possibly/probably for our pod reconcilier also)

@ahg-g
Copy link
Contributor

ahg-g commented Feb 10, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 10, 2025

We probably better use finer grained event handlers for handle Create/Update/Delete events for both InferenceModel and Pod: see example https://github.com/kubernetes-sigs/kueue/blob/96eb2e59692ae2bf1bb7341a073facbdbb0de12f/pkg/controller/core/localqueue_controller.go#L132

Those handlers should do minimal work (updating our local datastore) since they are invoked in the watch callback; work that requires any heavy lifting, like status updates, should continue to be done in Reconcile which is called by the worker threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants